Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Loop image doesn't match lesson content #247

Open
scottcpeterson opened this issue Sep 9, 2023 · 2 comments
Open

Loop image doesn't match lesson content #247

scottcpeterson opened this issue Sep 9, 2023 · 2 comments
Labels
type:clarification Suggest change for make lesson clearer

Comments

@scottcpeterson
Copy link
Contributor

scottcpeterson commented Sep 9, 2023

What is the problem?

The code on the Loop image is wrong. It is currently,

for filename in *.dat
do
echo cp "$filename" backup_"$filename"
done

When it should be

for filename in *.dat
do
echo "$filename"
cp "$filename" backup_"$filename"
done

Location of problem (optional)

Line 175 {alt='For Loop in Action'}

https://librarycarpentry.org/lc-shell/04-loops.html#for-loop-exercise

@scottcpeterson
Copy link
Contributor Author

Actually, the Stdout is correct in the image, it is just a confusing image as it doesn't follow the example in the lesson.

@kaitlinnewson kaitlinnewson reopened this Sep 12, 2023
@kaitlinnewson kaitlinnewson changed the title Loop image has incorrect code on it. Loop image doesn't match lesson content Sep 12, 2023
@kaitlinnewson
Copy link
Member

Hi @scottcpeterson, I've reopened this issue as I think what you've pointed out about the image not matching the lesson makes sense and is worth resolving - we should update the image so that it more closely matches the code in the lesson.

@kaitlinnewson kaitlinnewson added the type:clarification Suggest change for make lesson clearer label Sep 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:clarification Suggest change for make lesson clearer
Projects
None yet
Development

No branches or pull requests

2 participants