Friendly Collaboration Tip

[HaoZeke]

Dear Maintainers,
I noticed a few recent PRs (#52 , #53) and possibly others have been closed by commits which reproduce the exact PR contents. This is a poor practice. PRs are normally meant to be merged. Indeed, for new instructors, not being able to link to a merged PR might delay checkout as well.
best,
Friendly fellow Carpentries maintainer

[ciakovx]

Thank you Rohit, I appreciate your comment. The reason I was doing that is I did not realize that commits to the main branch would be pushed to the gh-pages branch as well. Someone from Carpentries added that functionality and I was not made aware that it worked that way. Once I started pushing the commits to the main branch, I noticed that they were pushed to the gh-pages automatically and the website was rebuilt. Do you happen to have any documentation discussing the relationship between main and gh-pages? Clarke

…

On Mon, Apr 19, 2021 at 6:36 PM Rohit Goswami ***@***.***> wrote: Dear Maintainers, I noticed a few recent PRs (#52 <#52> , #53 <#53>) and possibly others have been closed by commits which reproduce the exact PR contents. This is a poor practice. PRs are normally meant to be merged. Indeed, for new instructors, not being able to link to a merged PR might delay checkout as well. best, Friendly fellow Carpentries maintainer — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#57>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABTDILR5WB66ZCUDXJEBIXLTJS5A5ANCNFSM43G6EBFQ> .