Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

per #237 add alt txt to png #331

Merged
merged 3 commits into from
Jan 11, 2024
Merged

per #237 add alt txt to png #331

merged 3 commits into from
Jan 11, 2024

Conversation

jas58
Copy link
Contributor

@jas58 jas58 commented Dec 15, 2023

In row 37, updated the alt text code and description

#237 4th checkbox

In row 37, updated the alt text code and description
Copy link

github-actions bot commented Dec 15, 2023

Thank you!

Thank you for your pull request 😃

🤖 This automated message can help you check the rendered files in your submission for clarity. If you have any questions, please feel free to open an issue in {sandpaper}.

If you have files that automatically render output (e.g. R Markdown), then you should check for the following:

  • 🎯 correct output
  • 🖼️ correct figures
  • ❓ new warnings
  • ‼️ new errors

Rendered Changes

🔍 Inspect the changes: https://github.com/LibraryCarpentry/lc-open-refine/compare/md-outputs..md-outputs-PR-331

The following changes were observed in the rendered markdown documents:

 06-working-with-columns.md | 2 +-
 md5sum.txt                 | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)
What does this mean?

If you have source files that require output and figures to be generated (e.g. R Markdown), then it is important to make sure the generated figures and output are reproducible.

This output provides a way for you to inspect the output in a diff-friendly manner so that it's easy to see the changes that occur due to new software versions or randomisation.

⏱️ Updated at 2024-01-11 15:40:41 +0000

@jas58 jas58 requested a review from ostephens December 15, 2023 15:52
github-actions bot pushed a commit that referenced this pull request Dec 15, 2023
ostephens
ostephens previously approved these changes Jan 9, 2024
Copy link
Contributor

@ostephens ostephens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jas58 I don't think it's correct to say that "The top 'Show as' row of the OpenRefine grid changes after first sort command". I think this is just illustrating that the sort menu is added to the display (as in "An additional menu labeled Sort now follows the number of rows displayed.")

@ostephens ostephens dismissed their stale review January 9, 2024 17:36

Incorrect review

Now reads:
Note the addition of a menu called Sort appears after your first sort command. It follows the number of rows displayed.
@ostephens ostephens self-requested a review January 10, 2024 15:56
@@ -34,7 +34,7 @@ You can sort data in OpenRefine by clicking on the drop-down menu for the column

Once applied, locate the new "Sort" button at the top of the grid.

![](fig/sort-menu-highlight.png){alt='Addition of Sort menu to OpenRefine grid after first sort command'}
![New Sort menu appears above grid after first sort command](fig/sort-menu-highlight.png){alt="Note the addition of a menu called Sort appears after your first sort command. It follows the number of rows displayed."}
Copy link
Contributor

@ostephens ostephens Jan 10, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't read quite correctly to me. Should it be:

Note the addition of a menu called Sort which appears after your first sort command. It follows the number of rows displayed.

?

Copy link
Contributor Author

@jas58 jas58 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, Owen! inserted Which

github-actions bot pushed a commit that referenced this pull request Jan 11, 2024
@ostephens ostephens self-requested a review January 11, 2024 16:02
@ostephens ostephens merged commit 636407d into main Jan 11, 2024
3 checks passed
@ostephens ostephens deleted the jas58-patch-1 branch January 11, 2024 16:11
github-actions bot pushed a commit that referenced this pull request Jan 11, 2024
Auto-generated via {sandpaper}
Source  : 636407d
Branch  : main
Author  : Owen Stephens <[email protected]>
Time    : 2024-01-11 16:11:33 +0000
Message : Merge pull request #331 from LibraryCarpentry/jas58-patch-1

per #237 add alt txt to png
github-actions bot pushed a commit that referenced this pull request Jan 11, 2024
Auto-generated via {sandpaper}
Source  : 8dd19d6
Branch  : md-outputs
Author  : GitHub Actions <[email protected]>
Time    : 2024-01-11 16:12:43 +0000
Message : markdown source builds

Auto-generated via {sandpaper}
Source  : 636407d
Branch  : main
Author  : Owen Stephens <[email protected]>
Time    : 2024-01-11 16:11:33 +0000
Message : Merge pull request #331 from LibraryCarpentry/jas58-patch-1

per #237 add alt txt to png
github-actions bot pushed a commit that referenced this pull request Jan 16, 2024
Auto-generated via {sandpaper}
Source  : 8dd19d6
Branch  : md-outputs
Author  : GitHub Actions <[email protected]>
Time    : 2024-01-11 16:12:43 +0000
Message : markdown source builds

Auto-generated via {sandpaper}
Source  : 636407d
Branch  : main
Author  : Owen Stephens <[email protected]>
Time    : 2024-01-11 16:11:33 +0000
Message : Merge pull request #331 from LibraryCarpentry/jas58-patch-1

per #237 add alt txt to png
github-actions bot pushed a commit that referenced this pull request Jan 23, 2024
Auto-generated via {sandpaper}
Source  : 8dd19d6
Branch  : md-outputs
Author  : GitHub Actions <[email protected]>
Time    : 2024-01-11 16:12:43 +0000
Message : markdown source builds

Auto-generated via {sandpaper}
Source  : 636407d
Branch  : main
Author  : Owen Stephens <[email protected]>
Time    : 2024-01-11 16:11:33 +0000
Message : Merge pull request #331 from LibraryCarpentry/jas58-patch-1

per #237 add alt txt to png
github-actions bot pushed a commit that referenced this pull request Jan 30, 2024
Auto-generated via {sandpaper}
Source  : 8dd19d6
Branch  : md-outputs
Author  : GitHub Actions <[email protected]>
Time    : 2024-01-11 16:12:43 +0000
Message : markdown source builds

Auto-generated via {sandpaper}
Source  : 636407d
Branch  : main
Author  : Owen Stephens <[email protected]>
Time    : 2024-01-11 16:11:33 +0000
Message : Merge pull request #331 from LibraryCarpentry/jas58-patch-1

per #237 add alt txt to png
github-actions bot pushed a commit that referenced this pull request Feb 6, 2024
Auto-generated via {sandpaper}
Source  : 8dd19d6
Branch  : md-outputs
Author  : GitHub Actions <[email protected]>
Time    : 2024-01-11 16:12:43 +0000
Message : markdown source builds

Auto-generated via {sandpaper}
Source  : 636407d
Branch  : main
Author  : Owen Stephens <[email protected]>
Time    : 2024-01-11 16:11:33 +0000
Message : Merge pull request #331 from LibraryCarpentry/jas58-patch-1

per #237 add alt txt to png
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants