Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update 03-working-with-data.md #322

Merged
merged 6 commits into from
Nov 22, 2023
Merged

Update 03-working-with-data.md #322

merged 6 commits into from
Nov 22, 2023

Conversation

jas58
Copy link
Contributor

@jas58 jas58 commented Nov 6, 2023

replaced 'row' in figure title with 'record' for image 2 of 2 but also need higher quality resolution to zoom in

Suggested by co-instructor Sept 2023.

still looking for how to update the image

replaced row in title with record for image 2 of 2 but also need higher quality resolution to zoom in
Copy link

github-actions bot commented Nov 6, 2023

Thank you!

Thank you for your pull request 😃

🤖 This automated message can help you check the rendered files in your submission for clarity. If you have any questions, please feel free to open an issue in {sandpaper}.

If you have files that automatically render output (e.g. R Markdown), then you should check for the following:

  • 🎯 correct output
  • 🖼️ correct figures
  • ❓ new warnings
  • ‼️ new errors

Rendered Changes

🔍 Inspect the changes: https://github.com/LibraryCarpentry/lc-open-refine/compare/md-outputs..md-outputs-PR-322

The following changes were observed in the rendered markdown documents:

 03-working-with-data.md |   2 +-
 fig/records.png         | Bin 55399 -> 418993 bytes
 fig/rows.png            | Bin 56239 -> 414764 bytes
 md5sum.txt              |   2 +-
 4 files changed, 2 insertions(+), 2 deletions(-)
What does this mean?

If you have source files that require output and figures to be generated (e.g. R Markdown), then it is important to make sure the generated figures and output are reproducible.

This output provides a way for you to inspect the output in a diff-friendly manner so that it's easy to see the changes that occur due to new software versions or randomisation.

⏱️ Updated at 2023-11-20 20:25:30 +0000

github-actions bot pushed a commit that referenced this pull request Nov 6, 2023
@jas58
Copy link
Contributor Author

jas58 commented Nov 6, 2023

Should I make the screen shot after updating to 3.7? I'm in 3.6 @ostephens

@jas58
Copy link
Contributor Author

jas58 commented Nov 6, 2023

leftScreenshot 2023-11-06 143618
recordsScreenshot 2023-11-06 143707

@jas58
Copy link
Contributor Author

jas58 commented Nov 6, 2023

Pausing now to see if it all loads correctly.

github-actions bot pushed a commit that referenced this pull request Nov 6, 2023
@ostephens ostephens self-requested a review November 16, 2023 10:37
Copy link
Contributor

@ostephens ostephens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The new images you've added are JPG, but the existing images are PNG format and markdown in the lesson points to the PNG images.

I can't find any specific advice on which image format to use in carpentries lessons and either would work, but PNG seems to be the standard and what we've used elsewhere in the lessons - so can you remove the JPG versions and create PNG versions to replace the existing images?

@jas58 jas58 requested a review from ostephens November 20, 2023 20:24
@jas58
Copy link
Contributor Author

jas58 commented Nov 20, 2023

Hi Owen, I changed the files to png.

github-actions bot pushed a commit that referenced this pull request Nov 20, 2023
@ostephens ostephens merged commit 37046ac into main Nov 22, 2023
3 checks passed
@ostephens ostephens deleted the jas58-patch-1 branch November 22, 2023 15:17
github-actions bot pushed a commit that referenced this pull request Nov 22, 2023
Auto-generated via {sandpaper}
Source  : 37046ac
Branch  : main
Author  : Owen Stephens <[email protected]>
Time    : 2023-11-22 15:17:29 +0000
Message : Merge pull request #322 from LibraryCarpentry/jas58-patch-1

Update 03-working-with-data.md
github-actions bot pushed a commit that referenced this pull request Nov 22, 2023
Auto-generated via {sandpaper}
Source  : 9aeaea0
Branch  : md-outputs
Author  : GitHub Actions <[email protected]>
Time    : 2023-11-22 15:18:35 +0000
Message : markdown source builds

Auto-generated via {sandpaper}
Source  : 37046ac
Branch  : main
Author  : Owen Stephens <[email protected]>
Time    : 2023-11-22 15:17:29 +0000
Message : Merge pull request #322 from LibraryCarpentry/jas58-patch-1

Update 03-working-with-data.md
github-actions bot pushed a commit that referenced this pull request Nov 22, 2023
Auto-generated via {sandpaper}
Source  : 9aeaea0
Branch  : md-outputs
Author  : GitHub Actions <[email protected]>
Time    : 2023-11-22 15:18:35 +0000
Message : markdown source builds

Auto-generated via {sandpaper}
Source  : 37046ac
Branch  : main
Author  : Owen Stephens <[email protected]>
Time    : 2023-11-22 15:17:29 +0000
Message : Merge pull request #322 from LibraryCarpentry/jas58-patch-1

Update 03-working-with-data.md
github-actions bot pushed a commit that referenced this pull request Nov 28, 2023
Auto-generated via {sandpaper}
Source  : 9aeaea0
Branch  : md-outputs
Author  : GitHub Actions <[email protected]>
Time    : 2023-11-22 15:18:35 +0000
Message : markdown source builds

Auto-generated via {sandpaper}
Source  : 37046ac
Branch  : main
Author  : Owen Stephens <[email protected]>
Time    : 2023-11-22 15:17:29 +0000
Message : Merge pull request #322 from LibraryCarpentry/jas58-patch-1

Update 03-working-with-data.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants