Skip to content

Commit a66e354

Browse files
author
Olaf Hartig
committed
adapted the unit tests to the latest changes
1 parent 1232964 commit a66e354

File tree

3 files changed

+56
-16
lines changed

3 files changed

+56
-16
lines changed

src/test/java/org/linkeddatafragments/datasource/DataSourceTest.java

Lines changed: 34 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -15,15 +15,18 @@
1515
import org.linkeddatafragments.datasource.IDataSource;
1616
import org.linkeddatafragments.datasource.IFragmentRequestProcessor;
1717
import org.linkeddatafragments.fragments.LinkedDataFragment;
18+
import org.linkeddatafragments.fragments.tpf.TriplePatternElement;
1819
import org.linkeddatafragments.fragments.tpf.TriplePatternFragment;
1920
import org.linkeddatafragments.fragments.tpf.TriplePatternFragmentRequest;
21+
import org.linkeddatafragments.fragments.tpf.TriplePatternFragmentRequestImpl;
22+
import org.linkeddatafragments.util.TriplePatternElementParser;
2023

2124

2225
/**
2326
*
2427
* @author Bart Hanssens <[email protected]>
2528
*/
26-
public abstract class DataSourceTest {
29+
public abstract class DataSourceTest<TermType,VarType> {
2730
private static IDataSource ds;
2831

2932
/**
@@ -43,6 +46,9 @@ public static IDataSource getDatasource() {
4346
public static void setDatasource(IDataSource ds) {
4447
DataSourceTest.ds = ds;
4548
}
49+
50+
protected abstract TriplePatternElementParser<TermType,VarType>
51+
getTriplePatternElementParser();
4652

4753
/**
4854
* Copy the demo triple in the jar to a temp file.
@@ -84,15 +90,18 @@ public static JsonObject createConfig(String title, String desc, String type) {
8490
*/
8591
@Test
8692
public void testEmpty() {
87-
TriplePatternFragmentRequest request = new TriplePatternFragmentRequest() {
88-
public boolean isPageRequest() { return true; }
89-
public long getPageNumber() { return 1L; }
90-
public String getFragmentURL() { return "http://example.org/f"; }
91-
public String getDatasetURL() { return "http://example.org/"; }
92-
public String getSubject() { return "http://nothing.ldf.org"; }
93-
public String getPredicate() { return null; }
94-
public String getObject() { return null; }
95-
};
93+
final TriplePatternElementParser<TermType,VarType> tpeParser =
94+
getTriplePatternElementParser();
95+
96+
final TriplePatternFragmentRequest<TermType,VarType> request =
97+
new TriplePatternFragmentRequestImpl<TermType,VarType>(
98+
"http://example.org/f", // fragmentURL
99+
"http://example.org/", // datasetURL,
100+
true, // pageNumberWasRequested,
101+
1L, //pageNumber,
102+
tpeParser.parseIntoTriplePatternElement("http://nothing.ldf.org"), // subject,
103+
tpeParser.parseIntoTriplePatternElement(null), // predicate,
104+
tpeParser.parseIntoTriplePatternElement(null) ); //object
96105

97106
final IFragmentRequestProcessor proc = getDatasource().getRequestProcessor();
98107
final LinkedDataFragment ldf = proc.createRequestedFragment( request );
@@ -109,14 +118,25 @@ public void testEmpty() {
109118
*/
110119
@Test
111120
public void testEstimate() {
112-
TriplePatternFragmentRequest request = new TriplePatternFragmentRequest() {
121+
final TriplePatternElementParser<TermType,VarType> tpeParser =
122+
getTriplePatternElementParser();
123+
124+
final TriplePatternFragmentRequest<TermType,VarType> request =
125+
new TriplePatternFragmentRequest<TermType,VarType>() {
113126
public boolean isPageRequest() { return true; }
114127
public long getPageNumber() { return 1L; }
115128
public String getFragmentURL() { return "http://example.org/f"; }
116129
public String getDatasetURL() { return "http://example.org/"; }
117-
public String getSubject() { return "http://data.gov.be/catalog/ckanvl"; }
118-
public String getPredicate() { return null; }
119-
public String getObject() { return null; }
130+
131+
public TriplePatternElement<TermType,VarType> getSubject() {
132+
return tpeParser.parseIntoTriplePatternElement("http://data.gov.be/catalog/ckanvl");
133+
}
134+
public TriplePatternElement<TermType,VarType> getPredicate() {
135+
return tpeParser.parseIntoTriplePatternElement(null);
136+
}
137+
public TriplePatternElement<TermType,VarType> getObject() {
138+
return tpeParser.parseIntoTriplePatternElement(null);
139+
}
120140
};
121141

122142
final IFragmentRequestProcessor proc = getDatasource().getRequestProcessor();

src/test/java/org/linkeddatafragments/datasource/HdtDataSourceTest.java

Lines changed: 11 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,13 +1,17 @@
11
package test.java.org.linkeddatafragments.datasource;
22

33
import com.google.gson.JsonObject;
4+
import com.hp.hpl.jena.rdf.model.RDFNode;
5+
46
import java.io.File;
57
import org.junit.After;
68
import org.junit.AfterClass;
79
import org.junit.Before;
810
import org.junit.BeforeClass;
911
import org.linkeddatafragments.datasource.DataSourceFactory;
1012
import org.linkeddatafragments.datasource.hdt.HdtDataSourceType;
13+
import org.linkeddatafragments.util.TriplePatternElementParser;
14+
import org.linkeddatafragments.util.TriplePatternElementParserForJena;
1115
import org.rdfhdt.hdt.enums.RDFNotation;
1216
import org.rdfhdt.hdt.hdt.HDT;
1317
import org.rdfhdt.hdt.hdt.HDTManager;
@@ -17,10 +21,16 @@
1721
*
1822
* @author Bart Hanssens <[email protected]>
1923
*/
20-
public class HdtDataSourceTest extends DataSourceTest {
24+
public class HdtDataSourceTest extends DataSourceTest<RDFNode,String> {
2125

2226
private static File hdtfile;
2327

28+
@Override
29+
protected TriplePatternElementParser<RDFNode,String>
30+
getTriplePatternElementParser()
31+
{
32+
return TriplePatternElementParserForJena.getInstance();
33+
}
2434

2535
@BeforeClass
2636
public static void setUpClass() throws Exception {

src/test/java/org/linkeddatafragments/datasource/JenaTDBDataSourceTest.java

Lines changed: 11 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,7 @@
44

55
import com.hp.hpl.jena.query.Dataset;
66
import com.hp.hpl.jena.rdf.model.Model;
7+
import com.hp.hpl.jena.rdf.model.RDFNode;
78
import com.hp.hpl.jena.tdb.TDBFactory;
89

910
import java.io.File;
@@ -20,14 +21,23 @@
2021

2122
import org.linkeddatafragments.datasource.DataSourceFactory;
2223
import org.linkeddatafragments.datasource.tdb.JenaTDBDataSourceType;
24+
import org.linkeddatafragments.util.TriplePatternElementParser;
25+
import org.linkeddatafragments.util.TriplePatternElementParserForJena;
2326

2427
/**
2528
*
2629
* @author Bart Hanssens <[email protected]>
2730
*/
28-
public class JenaTDBDataSourceTest extends DataSourceTest {
31+
public class JenaTDBDataSourceTest extends DataSourceTest<RDFNode,String> {
2932
private static File jena;
3033
private static Dataset dataset;
34+
35+
@Override
36+
protected TriplePatternElementParser<RDFNode,String>
37+
getTriplePatternElementParser()
38+
{
39+
return TriplePatternElementParserForJena.getInstance();
40+
}
3141

3242
@BeforeClass
3343
public static void setUpClass() throws Exception {

0 commit comments

Comments
 (0)