From 7c5db60b3afa93a96a96dd864563a71176197188 Mon Sep 17 00:00:00 2001 From: Olaf Hartig Date: Fri, 25 Dec 2015 18:00:31 +0100 Subject: [PATCH] extended FIXME comments to refer to the corresponding three bug reports: https://github.com/LinkedDataFragments/Server.Java/issues/23 https://github.com/LinkedDataFragments/Server.Java/issues/24 and https://github.com/LinkedDataFragments/Server.Java/issues/25 --- .../datasource/hdt/HdtBasedRequestProcessorForTPFs.java | 1 + .../datasource/index/IndexRequestProcessorForTPFs.java | 1 + .../datasource/tdb/JenaTDBBasedRequestProcessorForTPFs.java | 1 + 3 files changed, 3 insertions(+) diff --git a/src/org/linkeddatafragments/datasource/hdt/HdtBasedRequestProcessorForTPFs.java b/src/org/linkeddatafragments/datasource/hdt/HdtBasedRequestProcessorForTPFs.java index cd029fe..3ed8dbe 100644 --- a/src/org/linkeddatafragments/datasource/hdt/HdtBasedRequestProcessorForTPFs.java +++ b/src/org/linkeddatafragments/datasource/hdt/HdtBasedRequestProcessorForTPFs.java @@ -72,6 +72,7 @@ protected LinkedDataFragment createFragment( // FIXME: The following algorithm is incorrect for cases in which // the requested triple pattern contains a specific variable // multiple times (e.g., ?x foaf:knows ?x ). + // see https://github.com/LinkedDataFragments/Server.Java/issues/23 // look up the result from the HDT datasource) int subjectId = subject.isVariable() ? 0 : dictionary.getIntID(subject.asTerm().asNode(), TripleComponentRole.SUBJECT); diff --git a/src/org/linkeddatafragments/datasource/index/IndexRequestProcessorForTPFs.java b/src/org/linkeddatafragments/datasource/index/IndexRequestProcessorForTPFs.java index fd56526..8e4c6d4 100644 --- a/src/org/linkeddatafragments/datasource/index/IndexRequestProcessorForTPFs.java +++ b/src/org/linkeddatafragments/datasource/index/IndexRequestProcessorForTPFs.java @@ -84,6 +84,7 @@ protected LinkedDataFragment createFragment( // FIXME: The following algorithm is incorrect for cases in which // the requested triple pattern contains a specific variable // multiple times (e.g., ?x foaf:knows ?x ). + // see https://github.com/LinkedDataFragments/Server.Java/issues/25 final Resource subject = s.isVariable() ? null : s.asTerm().asResource(); diff --git a/src/org/linkeddatafragments/datasource/tdb/JenaTDBBasedRequestProcessorForTPFs.java b/src/org/linkeddatafragments/datasource/tdb/JenaTDBBasedRequestProcessorForTPFs.java index 8aad998..094183e 100644 --- a/src/org/linkeddatafragments/datasource/tdb/JenaTDBBasedRequestProcessorForTPFs.java +++ b/src/org/linkeddatafragments/datasource/tdb/JenaTDBBasedRequestProcessorForTPFs.java @@ -69,6 +69,7 @@ protected LinkedDataFragment createFragment( // FIXME: The following algorithm is incorrect for cases in which // the requested triple pattern contains a specific variable // multiple times (e.g., ?x foaf:knows ?x ). + // see https://github.com/LinkedDataFragments/Server.Java/issues/24 Model model = tdb.getDefaultModel(); QuerySolutionMap map = new QuerySolutionMap();