0.1.13 regression on excluded

[pcause]

installed and i now see tasks that are in my excluded folders and they are still shown in the options as excluded folder. in a sub-folder of excluded folder which you had previously fixed to get working.

[Leonezz]

Can confirm, there are serious issue with the option system, they do not take effect sometimes.

[Leonezz]

I have make some fix to this issue, however, I have no clue why the view does not load all the items on opening of obisdian, and the options take effect only after some modifications are made to the files in the valut or plugin options.

[pcause]

just tried 0.1.14 and still broken. loaded, restarted and now i get nothing displayed. NOTHING AT ALL. clicked focus on today on or off no difference. no filter selected. I had accidentally turned off enable counters on filter panel. when i turn on again, i get the items from the excluded folders.

if it helps I have 2 folders listed, comma separated. basically:

vault/me/templates,vault/me/tests

and both are folders with subfolder. should skip all tasks in the folders and their subfolders.

[Leonezz]

yes it displays nothing on start, that is also an issue I am trying to resolve recently, unfortunately I have no clue yet. But if you trigger the re-renderring event by modify files or options, it should be back normal.

[FeralFlora]

I have the same issue, can't see anything and can't add tasks to inbox file or the daily note. When I try to change settings or add a task, the whole Tasks Calendar Wrapper sidebar tab becomes blank until I reopen it.

[YIRU69]

I updated to version 0.14 and encountered the same issue. Upon testing, it was discovered that the settings in the plugin section were not functioning properly at the start. The issue was only resolved after I switched to the 'Forward past from past' option.

[Leonezz]

@pcause @MSBack @YIRU69 , I think soma major changes are happening in the obsidian plugin api, originally I learned from https://marcus.se.net/obsidian-plugin-docs/user-interface/views how to set up a view plugin, but now the following code are throwing exceptions:

await this.app.workspace.getRightLeaf(false).setViewState({
    type: type,
    active: true,
});

this.app.workspace.revealLeaf(
    this.app.workspace.getLeavesOfType(type).first()!
);

And the following code are printing a array of lenth 0, in which it should include the leaf this view belongs:

console.log(this.app.workspace.getLeavesOfType(TIMELINE_VIEW))

All those problems caused the view ill-formed and it breaks the control flow where the settings should be loaded. I need more documents to locate where the issue is, if you happen to know where the developers can get more accurate documents of obsidian, please leave a comment.

[Leonezz]

Sorry for the inconvenience, but I need more digging to solve this.

[Leonezz]

I have made a release that seems working, but the underlying reason why these exceptions are thrown remains unclear.

[pcause]

0.1.15 doesn't fix the issue

[Leonezz]

0.1.15 doesn't fix the issue

Can you try backup your setting and re-install?

[pcause]

did it and no change

[Leonezz]

Need more information since it works perfectly fine in my system.

[YIRU69]

It fixs in my system.

[pcause]

I deleted the plugin and restarted. entered everything from scratch in options and still had the issue. remembered the comment above and turned off forward tasks from path and the exclude worked but with it enabled, the items from the excluded folders appear.

[YIRU69]

Yes, there is still a portion of the problem that has not been resolved for me. Although my defined tasks display normally, they still appear in the "unplanned" option. In fact, my "unplanned task" appears in the folder that has been excluded, so this is a problem. Additionally, if I enable the "forward task from task" option, the tasks from the excluded folder reappear. Therefore, I believe that the problem has not been fully resolved.

[YIRU69]

I deleted the plugin and restarted. entered everything from scratch in options and still had the issue. remembered the comment above and turned off forward tasks from path and the exclude worked but with it enabled, the items from the excluded folders appear.

You could try togle the "forward task from task" option.

[Leonezz]

I deleted the plugin and restarted. entered everything from scratch in options and still had the issue. remembered the comment above and turned off forward tasks from path and the exclude worked but with it enabled, the items from the excluded folders appear.

I deleted the plugin and restarted. entered everything from scratch in options and still had the issue. remembered the comment above and turned off forward tasks from path and the exclude worked but with it enabled, the items from the excluded folders appear.

You could try togle the "forward task from task" option.

That is weird cause in my test case the exclude path option works fine. Could you please tell if there is differences that you think might cause this issue? Below is a screen record I just made in my test vault.

2023-05-30-21-30-28.mp4

[pcause]

the exclude path folders have sub-folders where there are task. so i have a templates folder and it has subfolders with other templates. each folder has a task type template. there was a previous issue where a folder exclusion didn't exclude all subfolders that was fixed but seems to have reappeared

[Leonezz]

It comes out one detail I think might cause the issue, are there trailing '/' in your paths of the exclude path option? It might work in the earlier versions, but recently I updated the algorithm to judge if the given path is a parent path of a file, so currently the paths in the option should not have trailing '/'. @pcause @YIRU69 Could you please confirm if this is the case ?

[pcause]

no trailing / and no leading /, although all path specifications start at root. I have 2 paths specified.

[Leonezz]

the exclude path folders have sub-folders where there are task. so i have a templates folder and it has subfolders with other templates. each folder has a task type template. there was a previous issue where a folder exclusion didn't exclude all subfolders that was fixed but seems to have reappeared

This is it, I think I find the issue, will make a release to fix this soon, thanks for the information.

[pcause]

thanks

[Leonezz]

Hi @pcause @YIRU69 @MSBack , Thanks a lot for your feedback, I hope the latest release solves the issue here. BTW if you have some test cases that you think might be helpful for testing this plugin, please check out #25 , that will be very helpful!

[YIRU69]

It works!

[pcause]

worked for me as well. you really need to be clearer on where a leading / is needed when entering a path.

[Leonezz]

Glad to hear it works! I will come up with a document this weekend since there are already differences between options of this plugin and the original script.

[Leonezz]

Closing this, please check out #25 if it may!