Support tests using StrictMocking trait / extending our test case and using DisableReturnValueGenerationForTestDoubles (#67)

Author: ben-challis

src/Phpstan/Rule/ForbidLooseMock.php

@@ -12,6 +12,7 @@
 use PHPStan\Analyser\Scope;
 use PHPStan\Rules\Rule;
 use PHPStan\Rules\RuleErrorBuilder;
+use PHPUnit\Framework\Attributes\DisableReturnValueGenerationForTestDoubles;
 use PHPUnit\Framework\TestCase;
 
 /**
@@ -51,6 +52,10 @@ public function processNode(Node $node, Scope $scope): array
             return [];
         }
 
+        if ($reflection->getNativeReflection()->getAttributes(DisableReturnValueGenerationForTestDoubles::class) !== []) {
+            return [];
+        }
+
         return [RuleErrorBuilder::message('Forbidden call to "createMock", use "createStrictMock" instead.')->build()];
     }
 }

tests/phpstan/Rule/ForbidLooseMockTest.php

@@ -63,6 +63,18 @@ public function does_not_report_test_using_disabling_of_return_value_generation_
         $this->analyse([__DIR__.'/../data/TestCaseWithAttributeTest.php'], []);
     }
 
+    #[Test]
+    public function does_not_report_test_extending_our_test_case_using_disabling_of_return_value_generation_attribute(): void
+    {
+        $this->analyse([__DIR__.'/../data/OurTestCaseExtendingAndUsingAttributeTest.php'], []);
+    }
+
+    #[Test]
+    public function does_not_report_test_using_trait_and_using_disabling_of_return_value_generation_attribute(): void
+    {
+        $this->analyse([__DIR__.'/../data/OurTraitUsingAndUsingAttributeTest.php'], []);
+    }
+
     protected function getRule(): ForbidLooseMock
     {
         return new ForbidLooseMock();

tests/phpstan/data/OurTestCaseExtendingAndUsingAttributeTest.php

@@ -0,0 +1,19 @@
+<?php
+
+declare(strict_types=1);
+
+namespace Tests\Phpstan\Lendable\PHPUnitExtensions\data;
+
+use Lendable\PHPUnitExtensions\TestCase;
+use PHPUnit\Framework\Attributes\DisableReturnValueGenerationForTestDoubles;
+use PHPUnit\Framework\Attributes\Test;
+
+#[DisableReturnValueGenerationForTestDoubles]
+class OurTestCaseExtendingAndUsingAttributeTest extends TestCase
+{
+    #[Test]
+    public function loose_mock(): void
+    {
+        $this->createMock(\ArrayAccess::class);
+    }
+}

tests/phpstan/data/OurTraitUsingAndUsingAttributeTest.php

@@ -0,0 +1,22 @@
+<?php
+
+declare(strict_types=1);
+
+namespace Tests\Phpstan\Lendable\PHPUnitExtensions\data;
+
+use Lendable\PHPUnitExtensions\StrictMocking;
+use PHPUnit\Framework\Attributes\DisableReturnValueGenerationForTestDoubles;
+use PHPUnit\Framework\Attributes\Test;
+use PHPUnit\Framework\TestCase;
+
+#[DisableReturnValueGenerationForTestDoubles]
+class OurTraitUsingAndUsingAttributeTest extends TestCase
+{
+    use StrictMocking;
+
+    #[Test]
+    public function loose_mock(): void
+    {
+        $this->createMock(\ArrayAccess::class);
+    }
+}