-
-
Notifications
You must be signed in to change notification settings - Fork 884
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Provide thumbnail with RSS #581
Comments
I guess just the sites favicon? https://dev.lemmy.ml/static/assets/favicon.svg Can RSS feeds have svg thumbnails? If not there's an apple-touch-icon one. |
Pretty sure the issue is about including thumbnails for posts in the RSS feed. Apparently we forgot to add that in the initial implementation. |
The thumbnails (unless its an image post) aren't stored on the back-end yet. This will have to wait for #558 . |
We could also just include the full-size images. |
The pictshare_urls are full size, but the back end currently doesn't store any images, only the url field. |
the url field should be perfect, here a rss reference : |
@Nutomic There are now thumbnails in the post fetch, the |
I might be missing something here, but it looks like the https://rust-syndication.github.io/rss/rss/struct.Channel.html#method.image Edit: Forget that, we just need to put it in the html. |
Unfortunately stackoverflow is debating on it, but it looks like it needs to be an enclosure: https://rust-syndication.github.io/rss/rss/struct.Enclosure.html Basically if the pictshare_thumbnail column exists, we set an image enclosure for the item. @Nutomic u want this or should I do? |
I dont really care, but anyway its really low priority. |
This is easy enough to do with the following code, but enclosure requires length and mime fields. We could get the mime based on the thumbnail filename, but getting the size requires a network call to pict-rs, and thats just too slow.
|
I believe the What does seem to work in most readers is the <media:content url="https://lemmy.ml/pictrs/image/84ccd4ee-a278-4bf0-9d63-dad21add2e50.jpeg?thumbnail=256" medium="image"/> Here's what this looks like in Fluent Reader: |
Hi,
the RSS feed should provide a url for image or thumbnail.
regards,
Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.
The text was updated successfully, but these errors were encountered: