Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tiled windows don't look tiled #255

Open
vixalien opened this issue Apr 1, 2023 · 4 comments
Open

Tiled windows don't look tiled #255

vixalien opened this issue Apr 1, 2023 · 4 comments
Labels
enhancement Improve this extensions

Comments

@vixalien
Copy link

vixalien commented Apr 1, 2023

When you tile a window, say to the right with Tiling Assitant, it retains the round edges and still looks as a non-tiled application.

Here's some pictures for reference

Tiled window using GNOME native tiling

image

A closer look at the bottom right edge

image

Tiled window using Tiling Assistant

image

A closer look at the bottom right edge

image

Possible solution

Now I think this can be solved by adding the relevant tiling styles to a tiled window. For example, the above extension gets the tiled-top, tiled-left and "tiled-bottom` classes.

image

Here are the relevant styles in libadwaita,

It would be nice if Tiling Assistant could add these styles too.

@vixalien vixalien added the enhancement Improve this extensions label Apr 1, 2023
@3v1n0
Copy link
Collaborator

3v1n0 commented Apr 1, 2023

This is something that can't be handled at extension level without upstream support.

A change like #239 can help in the two-tiles cases, but it won't in other cases.
To support this in Ubuntu we introduced two patches:

They're both pretty small and the mutter one can probably be reworked to be merged upstream, but it's something we have to discuss still.

@3v1n0
Copy link
Collaborator

3v1n0 commented Apr 1, 2023

And they look as expected indeed:

image

@MagnusL3D-code
Copy link

Just wanted to come here and +1 to this since I was just about to create the same issue :)

@skewty
Copy link

skewty commented Dec 19, 2023

making the corners squared would solve #222

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improve this extensions
Projects
None yet
Development

No branches or pull requests

4 participants