Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

workers.error.log & workers.access.log not being created/written #177

Closed
jeffv opened this issue Dec 19, 2011 · 3 comments
Closed

workers.error.log & workers.access.log not being created/written #177

jeffv opened this issue Dec 19, 2011 · 3 comments

Comments

@jeffv
Copy link

jeffv commented Dec 19, 2011

It appears that the event bind is failing circa /plugins/logger.js:135

I can confirm that the 'worker' event does indeed happen, and that it is bindable.

It appears that the bind is happening long after the 'worker' event has already been emitted, resulting in the function never being called.

This was tested on node v0.4.7, v0.4.12 and cluster v0.7.6 and v0.7.7.
This also can be shown using /examples/logger.js.

@jeffv
Copy link
Author

jeffv commented Dec 19, 2011

This appears to have been introduced in commit a3fb1ec in v0.7.0

My feeling is that the callback for creating the directory is delaying 'worker' event bind and causing the issue. We have a race condition between the server starting workers and the directory being created.

@telendt
Copy link

telendt commented Dec 20, 2011

IMHO it's duplicate of #169.

@jeffv
Copy link
Author

jeffv commented Dec 20, 2011

Ah yes. It is. You are correct. Going to close this issue in favor of #169.

@jeffv jeffv closed this as completed Dec 20, 2011
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants