We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
While reviewing https://github.com/cristim/autospotting/pull/175 I realised that we could create NewObject methods, in order to improve the way we instantiate objects such as: https://github.com/cristim/autospotting/blob/2c9e019ffc2f7c2025236433f180d4e519a5294e/core/main.go#L64 https://github.com/cristim/autospotting/blob/2c9e019ffc2f7c2025236433f180d4e519a5294e/core/region.go#L316 https://github.com/cristim/autospotting/blob/2c9e019ffc2f7c2025236433f180d4e519a5294e/core/main.go#L20
This would for example help for loading the default configuration and overiding it with special ASG configuration.
The default configuration could be loaded here: https://github.com/cristim/autospotting/blob/2c9e019ffc2f7c2025236433f180d4e519a5294e/core/main.go#L20 While the ASG configuration would be added here: https://github.com/cristim/autospotting/blob/2c9e019ffc2f7c2025236433f180d4e519a5294e/core/region.go#L296 - the call to load ASG (https://github.com/cristim/autospotting/blob/2c9e019ffc2f7c2025236433f180d4e519a5294e/core/region.go#L316) would be improved by the NewAutoscalingGroup method which would load the configuration for this ASG based on the default configuration of the region.
NewAutoscalingGroup
Instead of doing it later during the process here: https://github.com/cristim/autospotting/blob/2c9e019ffc2f7c2025236433f180d4e519a5294e/core/autoscaling.go#L176 as it doesn't make that much sense.
EDIT: updated links to replace master by a commit relevant at that time; otherwise the lines weren't matching anything meaningful anymore.
master
The text was updated successfully, but these errors were encountered:
@xlr-8 I'd love to see a PR for this.
Sorry, something went wrong.
Yeah me too, I've been off computer lately, sorry
I'm working on something like this in preparation for a new feature that touches this area. Stay tuned.
No branches or pull requests
Issue type
Summary
While reviewing https://github.com/cristim/autospotting/pull/175 I realised that we could create NewObject methods, in order to improve the way we instantiate objects such as:
https://github.com/cristim/autospotting/blob/2c9e019ffc2f7c2025236433f180d4e519a5294e/core/main.go#L64
https://github.com/cristim/autospotting/blob/2c9e019ffc2f7c2025236433f180d4e519a5294e/core/region.go#L316
https://github.com/cristim/autospotting/blob/2c9e019ffc2f7c2025236433f180d4e519a5294e/core/main.go#L20
Details
This would for example help for loading the default configuration and overiding it with special ASG configuration.
The default configuration could be loaded here: https://github.com/cristim/autospotting/blob/2c9e019ffc2f7c2025236433f180d4e519a5294e/core/main.go#L20
While the ASG configuration would be added here: https://github.com/cristim/autospotting/blob/2c9e019ffc2f7c2025236433f180d4e519a5294e/core/region.go#L296 - the call to load ASG (https://github.com/cristim/autospotting/blob/2c9e019ffc2f7c2025236433f180d4e519a5294e/core/region.go#L316) would be improved by the
NewAutoscalingGroup
method which would load the configuration for this ASG based on the default configuration of the region.Instead of doing it later during the process here: https://github.com/cristim/autospotting/blob/2c9e019ffc2f7c2025236433f180d4e519a5294e/core/autoscaling.go#L176 as it doesn't make that much sense.
EDIT: updated links to replace
master
by a commit relevant at that time; otherwise the lines weren't matching anything meaningful anymore.The text was updated successfully, but these errors were encountered: