Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Project Structure #82

Open
zdfs opened this issue Dec 11, 2015 · 5 comments
Open

Project Structure #82

zdfs opened this issue Dec 11, 2015 · 5 comments

Comments

@zdfs
Copy link
Collaborator

zdfs commented Dec 11, 2015

There have been a lot of conversation so far relating to the project structure, so I'm going to summarize them all here.

  1. Should we move to a src and dist directory structure? #59: Src and dist structure.
  2. Bower package not found #79: Bower package not found.
  3. Karma Reporter #71: Karma Reporter

We have the following criteria we'd like to solve:

  1. Tagged releases on Github and NPM.
  2. Src and dist folders in the project.
  3. Lea would like the latest version for download at any time.
  4. Move website JS files to separate directory?

We also don't want the project to be more work than it already is. So let's take a look at this post-commit hook by Domenic: https://gist.github.com/domenic/ec8b0fc8ab45f39403dd.

I'd like to get SauceLabs or Browserstack set up as well. We can get a free account since this is open source.

Last, we want to consider the possibility of being able to execute the karma tests in-browser, as part of the gh-pages branch. Currently, I only know of QUnit doing this well. Haven't really seen solutions for Karma.

@softwarespot
Copy link

What about introducing a style guide? Perhaps adding jscs to gulp and using Airbnb's Style Guide

@dperrymorrow
Copy link
Collaborator

we have JShint running as a pre-processor on our test suite
right now its pretty loose, but we may tighten it up in the future
see #64

@LeaVerou
Copy link
Owner

Wellll, we have tags now :)

@softwarespot
Copy link

@dperrymorrow, I was thinking more along the lines of conformity with such things as quotation style, white-space, named functions etc.. something JSHint isn't designed for.

@dperrymorrow
Copy link
Collaborator

@softwarespot

I was thinking more along the lines of conformity with such things as quotation style, white-space, named functions etc.. something JSHint isn't designed for.

See issue #37 @LeaVerou is pretty opposed to very opinionated linters.
However if you have a solution feel free to propose it. Im not married to JsHint.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants