You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I wanted to add a dataset to elements created with $.create, and got browser errors.
It's obviously not implemented, but i think it should be.
Would a patch implementing that be accepted?
set: overload(function(property, value) {
if (property in $.setProps) {
$.setProps[property].call(this, value);
}
// new code
else if (property === "dataset") { /// or value instanceof DOMStringMap ?
for (const key of Object.keys(value)) {
this.dataset[key]=value[key]
}
}
// end new
else if (property in this) {
this[property] = value;
}
else {
this.setAttribute(property, value);
}
}, 0),
As a side note: start/inside is a name combination i stumble upon all the time, so i did this in my regular startup:
Sure, feel free to send it! Though keep in mind Bliss v2 is where it's at, the Bliss v1 code is largely frozen. Bliss v2 is basically ready except the docs are not there, which is why it hasn't launched :/
I wanted to add a dataset to elements created with $.create, and got browser errors.
It's obviously not implemented, but i think it should be.
Would a patch implementing that be accepted?
As a side note: start/inside is a name combination i stumble upon all the time, so i did this in my regular startup:
The text was updated successfully, but these errors were encountered: