Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

recent minimatch update to 10 causes a node 20 dependency #271

Closed
spdaley opened this issue Sep 11, 2024 · 4 comments
Closed

recent minimatch update to 10 causes a node 20 dependency #271

spdaley opened this issue Sep 11, 2024 · 4 comments
Labels
Bug Something isn't working

Comments

@spdaley
Copy link
Contributor

spdaley commented Sep 11, 2024

The recent minimatch update done #244 has added a node 20 dependency to this module. I'm not sure if that's intentional or accidental so submitting this just in case.

I don't see a published supported node version so maybe this is ok and my project can just deal with it but figured I'd submit this to be sure.

Thanks.

@danielpza danielpza added the Bug Something isn't working label Sep 11, 2024
@danielpza
Copy link
Member

Hey, thanks for reaching out.

I think we don't have a set minimum supported node version but I figure we want to support the current node LTS versions, that would include node 18.

I think it's ok to downgrade minimatch, it would be great if you'd be willing to open a PR :)

@spdaley
Copy link
Contributor Author

spdaley commented Sep 11, 2024

I'll give it a shot.

@spdaley
Copy link
Contributor Author

spdaley commented Sep 11, 2024

#272

I can't seem to run yarn test so not sure if there is anything wrong but I couldn't do that in the original repo either.

danielpza pushed a commit that referenced this issue Sep 11, 2024
#271

downgrade the minimatch dependency from 10.0.1 to 9.0.5 to remove a node
20 dependency.
@danielpza
Copy link
Member

danielpza commented Sep 11, 2024

Fixed in v3.5.1. Thanks for contributing @spdaley ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants