Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement]: Sign the MelonLoader assembly (give it a strong name) #767

Open
HAHOOS opened this issue Oct 8, 2024 · 1 comment
Open
Labels
Improvement New feature or request Planned This issue is planned to be worked on

Comments

@HAHOOS
Copy link
Contributor

HAHOOS commented Oct 8, 2024

Describe the new feature or enhancement

I've been working on a plugin and I have been trying to make it as backwards compatible as possible. An issue I am encountering is that I cannot reference two versions, because of them not having a strong name, which makes it hard to make plugins/mods compatible with older versions, because of changed methods, non-existent variables etc. I think by signing and giving ML a strong name in the future might help other people make their "Melons" also backwards compatible. Obviously I'm not saying that all older versions should be given a strong name and reuploaded to Github, but in future releases I think it could help some people (not a lot but still).

@HerpDerpinstine HerpDerpinstine added Improvement New feature or request Planned This issue is planned to be worked on labels Oct 8, 2024
@HAHOOS
Copy link
Contributor Author

HAHOOS commented Oct 8, 2024

It seems that I have been able to resolve the issue myself, but I had to download the source code, sign the ML v0.5.7 and build it for VS to let me build my project correctly. I have tested the issue I was experiencing ( MelonLaunchOptions in ML 0.5.7 having Debug.Enabled and in later versions it being Core.IsDebug) and it seems to work correctly.

So if anyone is wondering how you can reference 2 versions of MelonLoader, that's how you do it. Although I find it unlikely that anyone will find it required to use 2 versions

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Improvement New feature or request Planned This issue is planned to be worked on
Projects
None yet
Development

No branches or pull requests

2 participants