Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v6 Menu arrangement #535

Open
promatik opened this issue Jul 1, 2023 · 1 comment
Open

v6 Menu arrangement #535

promatik opened this issue Jul 1, 2023 · 1 comment

Comments

@promatik
Copy link
Contributor

promatik commented Jul 1, 2023

I don't love the way the menus are organized in the new v6 demo, it makes the theme highlight everything ...

Any chance we can ->flatten() the addons group?

image

@tabacitu
Copy link
Member

tabacitu commented Jul 2, 2023

Good catch! I did that for two reasons:

Reason 1. To have fewer first-level items in total, so that it looks better in our default view which is horizontal:

CleanShot 2023-07-02 at 14 34 27

With the amount of items we had previously, it looked OK on 1440px but on 1280px one item.

Reason 2. It makes more sense to me this way:

  • addons are grouped together
  • examples are grouped together

What we COULD do... ideally... is to allow multi-level menus. That way we can:

  • group 3 items into "Authentication"
  • group 3 items into "News"
  • then when you're in one of those CRUDs only the third-level item would be highlighted

But that needs to be done inside all 3 themes 🤦‍♂️ So how about...

What we SHOULD DO... is change the active highlight on this theme, so that it makes purple only the CURRENT ITEM, not the entire dropdown the current item is in;


In the end, I think this menu change highlighted a design problem. Rather than an organisation problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

No branches or pull requests

2 participants