Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

php artisan backpack:build on our demo highlights a bunch of minor problems #159

Open
2 of 9 tasks
tabacitu opened this issue Oct 10, 2022 · 2 comments
Open
2 of 9 tasks

Comments

@tabacitu
Copy link
Member

tabacitu commented Oct 10, 2022

Bug report

What I did:

php artisan backpack:build

What I expected to happen:

Everything work. Solve world hunger. Bring world peace. Help humanity ascend to a higher plane of understanding.

What happened:

NONE of the above!!! 😱 I don't think it's worth addressing world hunger, world peace in v5 though... those might take too much time to develop (6+ months probably) so maybe we focus on the minor things that didn't work? We can probably fix those in v5.

Here's a few things I noticed:

  • 🟡 didn't ask me what kind of validation I want... so it just created Requests for all models; bleah; @promatik
  • 🟡 highlighted how confusing up our example entities are, the ones that relate to Monster - sorry @pxpm but PostalBoxes, PostalBoxer, Recommends, Sentiments, Stars, Universes, Wishes, Balls, Bills, Graffiti... those don't make sense... let's spend 30min on it together, and see how we can rename them, so that when people look at them, they just "get it";
  • 🔵 a new admin/pet sidebar item has been added, even if it existed; I wonder why... and if there actually is anything to fix here or it's just the way it is; (the route didn't get created, which is ok, it existed in the pet-shop prefix); same thing happens for admin/skill, admin/passport, admin/owner, admin/invoice, admin/comment, admin/badge
  • ❓add Wish doesn't work... error 500... why?
  • ❓add Story doesn't work... error 500... why?
  • ❓add PostalBoxer doesn't work... error 500... why?
  • ❓add PostalBox doesn't work... error 500... why?
  • ❓add Address doesn't work... error 500... why?
  • 🔵 a new admin/product sidebar item has been added, even if it already existed as a subitem above; perhaps the check we do is a little too strict? I don't know how it works, but off the top of my head, if there's an item pointing to admin/product in the sidebar... we should no longer add it; so... route-based;
@tabacitu
Copy link
Member Author

We decided to keep the Monster entities the same... no matter how much we try, they still won't make too much sense, and won't be referred as "Add Sentiment" but "Add select2_from_ajax_multiple". But for reference here they are:

  • address - Monster hasOne Address
  • ball - Monster morphOne Ball
  • bill - Monster morphToMany Bill
  • graffiti - Grafitti belongsTo Monster
  • postal box - Monster hasMany PostalBox (select)
  • postal boxer - Monster hasMany PostalBoxer (repeatable)
  • recommend - Monster morphToMany Recommend
  • sentiment - Monster morphOne Sentiment
  • star - Monster morphMany Star
  • universe - Monster morphMany Universe
  • wish - Monster hasOne Wish

Copy link

stale bot commented Feb 11, 2024

Hi there!

Is this still an issue? No activity in 60 days. I'm going to mark it as stale for now, and close it in 14 days if no further activity occurs. I know you guys are all busy, but if this is important to you please reply or something, so I know not to close it.

Thank you!

--
Justin Case
The Backpack Robot

@stale stale bot added stale and removed stale labels Feb 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

No branches or pull requests

4 participants