Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 [BUG] - youtube.com #292

Closed
LanikSJ opened this issue Oct 5, 2024 · 15 comments
Closed

🐛 [BUG] - youtube.com #292

LanikSJ opened this issue Oct 5, 2024 · 15 comments
Labels
bug Something isn't working help wanted Extra attention is needed outdated

Comments

@LanikSJ
Copy link
Owner

LanikSJ commented Oct 5, 2024

Description

The header bar is cut off you don't see subscriptions or other header links for that matter.

Ad Blocker Name

uBlock Origin

Browser Name

Chrome (Chromium, Brave etc)

Reproduction steps

  1. Go to youtube.com
  2. Make sure you're logged in
  3. Watch a video
  4. Observe the same missing header

Screenshots

image

Config

uBlock Origin: 1.60.0
Chromium: 129
filterset (summary):
 network: 294273
 cosmetic: 322173
 scriptlet: 57137
 html: 0
listset (total-discarded, last-updated):
 added:
  https://adguardteam.github.io/AdGuardSDNSFilter/Filters/filter.txt: 65278-2367, 1d.3h.23m
  https://curbengh.github.io/pup-filter/pup-filter.txt: 199-0, 6m
  https://gitflic.ru/project/magnolia1234/bypass-paywalls-clean-filters/blob/raw?file=bpc-paywall-filter.txt: 1108-2, 6m
  https://raw.github.com/liamja/Prebake/master/obtrusive.txt: 1072-72, 5m
  https://raw.github.com/ryanbr/fanboy-adblock/master/fake-news.txt: 584-5, 5m
  https://raw.githubusercontent.com/IDKwhattoputhere/uBlock-Filters-Plus/master/uBlock-Filters-Plus.txt: 651-0, 1d.3h.23m
  https://raw.githubusercontent.com/LanikSJ/ubo-filters/main/filters/combined-filters.txt: 1387-6, 5m
  https://raw.githubusercontent.com/LanikSJ/ubo-filters/main/filters/malware-domains.txt: 15717-105, 5m
  https://raw.githubusercontent.com/LanikSJ/ubo-filters/master/filters/ubo-filters.txt: 682-6, 6m
  https://raw.githubusercontent.com/LanikSJ/webannoyances/master/ultralist.txt: 43985-39, 2m
  https://raw.githubusercontent.com/RedDragonWebDesign/block-everything/master/block-everything.txt: 636-5, 4m
  https://raw.githubusercontent.com/bogachenko/fuckfuckadblock/master/fuckfuckadblock-mining.txt: 152-0, 4h.57m
  [25 lists not shown]: [too many]
 default:
  user-filters: 4-0, never
  ublock-filters: 40355-657, 6m Δ
  ublock-badware: 11584-7, 6m Δ
  ublock-privacy: 1296-24, 6m Δ
  ublock-unbreak: 2471-3, 6m Δ
  ublock-quick-fixes: 164-0, 6m Δ
  easylist: 85752-37756, 6m Δ
  easyprivacy: 53139-3794, 6m Δ
  urlhaus-1: 25350-0, 6m
  plowe-0: 3552-326, 11d.5h.17m
filterset (user): [array of 4 redacted]
switchRuleset:
 added: [array of 1 redacted]
userSettings:
 advancedUserEnabled: true
 cloudStorageEnabled: true
hiddenSettings: [none]
supportStats:
 allReadyAfter: 267 ms (selfie)
 maxAssetCacheWait: 128 ms
 cacheBackend: indexedDB

OS

Mac

@LanikSJ LanikSJ added bug Something isn't working help wanted Extra attention is needed labels Oct 5, 2024
@LanikSJ
Copy link
Owner Author

LanikSJ commented Oct 25, 2024

@Sonic5435325 looks like this is no longer a problem. Can you confirm? Thanks!

@Sonic5435325
Copy link

I think I already fixed this bug but I'll double check tomorrow

@Sonic5435325
Copy link

Also note: while opening the sidebar menu while you're on a video you can't scroll, I'll fix that as well

@LanikSJ
Copy link
Owner Author

LanikSJ commented Oct 25, 2024

Still seeing the issue. 😔

@Sonic5435325
Copy link

Can't reproduce atm, I tried on a video and it works fine after going back to the homepage

@LanikSJ
Copy link
Owner Author

LanikSJ commented Oct 26, 2024

I have been trying to track down the problem myself but I can't seem to find it.

image
I have a whole bunch of filters I'm not sure if one of them is the problem however.

@Sonic5435325
Copy link

youtube.com###contentContainer.tp-yt-app-drawer:style(padding: unset !important;) seems to be causing it, but that was the filter I used to prevent the Shorts video pages from displaying incorrectly...

@LanikSJ
Copy link
Owner Author

LanikSJ commented Oct 26, 2024

Let me add it to my whitelist and do some testing I'll let you know later on tonight or tomorrow.

EDIT: Fixed it right up. 👍 At least on the front page. I'll watch some videos and see if it's fixed there too.

youtube.com#@##contentContainer.tp-yt-app-drawer:style(padding: unset !important;)

@Sonic5435325
Copy link

youtube.com###contentContainer.tp-yt-app-drawer:style(padding: var(--app-drawer-content-padding, 120px 0) !important;) seems to work OK as a replacement, but the sidebar is cut off a little when you view a short.

@Sonic5435325
Copy link

Sonic5435325 commented Oct 27, 2024

Looked a bit more into it... youtube.com###contentContainer.tp-yt-app-drawer[swipe-open].tp-yt-app-drawer::after, tp-yt-app-drawer:style(position: absolute !important; bottom: 0 !important;) is the filter that seems to be causing the problems on the Shorts page, I'll have to fix that too

@LanikSJ
Copy link
Owner Author

LanikSJ commented Oct 27, 2024

Thank you 🙏 🙂

@Sonic5435325
Copy link

Is the issue still ongoing? If not, this should probably be closed already.

@LanikSJ
Copy link
Owner Author

LanikSJ commented Oct 28, 2024

Yes we're all good. You're right I forgot to close it.

@LanikSJ LanikSJ closed this as completed Oct 28, 2024
@Sonic5435325
Copy link

Seems to be another issue on the video page when you view a short where the header gets hidden, can you test?

@LanikSJ
Copy link
Owner Author

LanikSJ commented Nov 2, 2024

I checked and I don't see the problem. The menu on the left is hidden but I like that as there's more room for videos etc.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 6, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working help wanted Extra attention is needed outdated
Projects
None yet
Development

No branches or pull requests

2 participants