Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 [BUG] - GitLab PRs Look Pretty Broken #228

Closed
LanikSJ opened this issue Aug 2, 2024 · 5 comments
Closed

🐛 [BUG] - GitLab PRs Look Pretty Broken #228

LanikSJ opened this issue Aug 2, 2024 · 5 comments
Labels
bug Something isn't working outdated

Comments

@LanikSJ
Copy link
Owner

LanikSJ commented Aug 2, 2024

Description

GitLab PRs look broken you can't really read any of the headings or text.

Ad Blocker Name

uBlock Origin

Browser Name

Chrome (Chromium, Brave etc)

Reproduction steps

  1. Go to https://gitlab.com
  2. Login / create account
  3. Create a repository
  4. Push some code
  5. Open a PR
  6. See breakage

Screenshots

Screenshot 2024-08-02 at 4 41 09 PM

Config

uBlock Origin: 1.59.0
Chromium: 127
filterset (summary):
 network: 367689
 cosmetic: 314804
 scriptlet: 55164
 html: 0
listset (total-discarded, last-updated):
 added:
  https://adguardteam.github.io/AdGuardSDNSFilter/Filters/filter.txt: 67392-2016, 1d.11h.46m
  https://malware-filter.gitlab.io/pup-filter/pup-filter.txt: 189-0, 15h.26m
  https://raw.github.com/ryanbr/fanboy-adblock/master/fake-news.txt: 584-5, 1d.11h.45m
  https://raw.githubusercontent.com/IDKwhattoputhere/uBlock-Filters-Plus/master/uBlock-Filters-Plus.txt: 651-0, 1d.11h.46m
  https://raw.githubusercontent.com/LanikSJ/ubo-filters/main/filters/malware-domains.txt: 104810-606, 1h.25m
  https://raw.githubusercontent.com/LanikSJ/ubo-filters/main/filters/ubo-filters.txt: 677-0, 15h.26m
  https://raw.githubusercontent.com/LanikSJ/ubo-filters/main/filters/youtube-antiadblock.txt: 16-0, 1h.25m
  https://raw.githubusercontent.com/LanikSJ/ubo-filters/master/filters/combined-filters.txt: 2344-91, 15h.25m
  https://raw.githubusercontent.com/LanikSJ/webannoyances/master/ultralist.txt: 43248-1424, never
  https://raw.githubusercontent.com/RedDragonWebDesign/block-everything/master/block-everything.txt: 628-2, 1d.11h.45m
  https://raw.githubusercontent.com/bogachenko/fuckfuckadblock/master/fuckfuckadblock-mining.txt: 152-0, 2d.12h.58m
  https://raw.githubusercontent.com/hoshsadiq/adblock-nocoin-list/master/nocoin.txt: 484-2, 1d.11h.46m
  [23 lists not shown]: [too many]
 default:
  user-filters: 0-0, never
  easylist: 87727-40061, 1h.25m Δ
  easyprivacy: 53045-4077, 1h.25m Δ
  plowe-0: 3548-329, 5d.20h.15m
  ublock-badware: 10114-3, 1h.25m Δ
  ublock-filters: 39454-709, 1h.25m Δ
  ublock-privacy: 1049-121, 1h.25m Δ
  ublock-quick-fixes: 151-0, 1h.25m Δ
  ublock-unbreak: 2421-5, 1h.25m Δ
  urlhaus-1: 29150-0, 4h.9m
filterset (user): [empty]
switchRuleset:
 added: [array of 1 redacted]
userSettings:
 advancedUserEnabled: true
 cloudStorageEnabled: true
hiddenSettings: [none]
supportStats:
 allReadyAfter: 154 ms (selfie)
 maxAssetCacheWait: 77 ms
 cacheBackend: indexedDB

OS

Mac

@LanikSJ LanikSJ added the bug Something isn't working label Aug 2, 2024
@LanikSJ
Copy link
Owner Author

LanikSJ commented Aug 2, 2024

I'm not really that good with CSS @Sonic5435325 maybe you can take a look.

@Sonic5435325
Copy link

I'm not really seeing this on my side, must be a repo owner kinda thing, can you pull up the filters that come up in the uBlock Origin logger?

@Sonic5435325
Copy link

Sonic5435325 commented Aug 3, 2024

Oh nvm I misread, it's on Gitlab and not Github, I'll take a look
Edit: There is also sticky headers on gitlab.com and forum.gitlab.com. I'll work on that next.

@Sonic5435325
Copy link

Ah ok found it. gitlab.com##.navbar-gitlab.navbar, .nav-sidebar, .right-sidebar-expanded.right-sidebar.js-right-sidebar.js-issuable-sidebar:style(position: absolute !important;) is affecting it. Should definitely be changed up.

@LanikSJ
Copy link
Owner Author

LanikSJ commented Aug 3, 2024

Yes thank you looks much better.
image
Same PR BTW. 🙂

@LanikSJ LanikSJ closed this as completed Aug 3, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 8, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working outdated
Projects
None yet
Development

No branches or pull requests

2 participants