Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Massive performance drop with Nether lava lakes. Room for optimization? #21

Closed
chrisunfocused opened this issue Aug 30, 2020 · 2 comments
Labels
duplicate This issue or pull request already exists wontfix This will not be worked on

Comments

@chrisunfocused
Copy link

Self explanatory more or less. Every lava block in the nether seems to be calculated individually, which causes massive slowdowns.

I did not have this issue with Optifine dynamic lighting. I'm assuming that there is some clever optimization taking place there.
I'm not sure what that would be, but I thought I'd bring it up!

@LambdAurora
Copy link
Owner

Does this happen only with LambDynamicLights?

@LambdAurora
Copy link
Owner

So, I recently thought about this issue again, and my guesses are it's because of chunk rebuilding, fluids in general have some special geometry which increases the difficulty to chunk rebuild efficiently and it's related to #16.

The only fixes are, either use Sodium or Canvas once it has native handheld lighting. With the first chunk rebuilding is not a big issue and the second chunk rebuilding can be avoided in the future.

But globally there's nothing that can be done in this mod (at least for now). We're at the mercy of how lighting works in Minecraft.

@LambdAurora LambdAurora added duplicate This issue or pull request already exists wontfix This will not be worked on labels Nov 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
duplicate This issue or pull request already exists wontfix This will not be worked on
Projects
None yet
Development

No branches or pull requests

2 participants