Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] OnJoinRequested is Broken in Unity Package #2

Open
ryanhlewis opened this issue May 19, 2022 · 1 comment
Open

[BUG] OnJoinRequested is Broken in Unity Package #2

ryanhlewis opened this issue May 19, 2022 · 1 comment
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@ryanhlewis
Copy link

ryanhlewis commented May 19, 2022

Describe the bug
The OnJoinRequested callback is completely broken, no matter the amount of times I call "invoke", subscribe to the event, or elsewise. In fact, it's subscribed to in the main DiscordManager.cs file, with this line of code:

        client.OnJoinRequested += (s, args) => Debug.Log("[DRP] Join Requested");

Yet, that Debug is never called. No matter how many times I click "Request to Join" from a Discord client on the same computer or another, with multiple different accounts. However, the Join callback works perfectly, along with the Join subscribe, so I assume this part of the library is somehow just out-of-date or I'm using it wrong, but I've poured through the "Discord Game Invite Example" Unity scene, which seems to be broken as well.

To Reproduce
Steps to reproduce the behavior:

  1. Set up a simple Discord Manager with a Party
  2. Try joining and requesting to join
  3. Notice in Debug.Log that the only event ever registered by the Logger is the Join Event

Expected behavior
I expect that callback, clearly defined in the CS file, to actually callback. I expect, too, to see an event that pops up claiming that a Join Request event was received by the Logger, just like it pops up claiming the Join event was received.

Desktop (please complete the following information):

  • OS: Windows 10
  • Framework: Unity 2020 .NET 4+
  • Library Version: 1.0.209-CI00209

Logs

It's the lack of logs that's bothering me. I have the system perfectly working with Join events and Join subscriptions. The JoinRequest event just seems to not work.
@ryanhlewis ryanhlewis added the bug Something isn't working label May 19, 2022
@Lachee
Copy link
Owner

Lachee commented May 19, 2022

Yeah, you can thank Discord for this.

Pretty sure the OnJoinRequested is actually removed from Discord now, as they decided to make that notification in the Discord client instead. It use to work, and it use to be awesome and super swish :c

I'll double check this when I have the time.

@Lachee Lachee added the good first issue Good for newcomers label May 19, 2022
@Lachee Lachee transferred this issue from Lachee/discord-rpc-csharp Aug 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants