Skip to content

Commit 94d2d91

Browse files
Merge pull request #583 from Labelbox/kkim/fix-datarow-test
[AL-0] Fix datarow test due to precomputedEmbeddings field automatically added
2 parents 7b2bbb9 + c7eeb0d commit 94d2d91

File tree

1 file changed

+17
-6
lines changed

1 file changed

+17
-6
lines changed

tests/integration/test_data_rows.py

Lines changed: 17 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -57,6 +57,12 @@ def make_metadata_fields_dict():
5757
return fields
5858

5959

60+
def filter_precomputed_embeddings(metadata_fields):
61+
return list(
62+
filter(lambda md: md["name"] != "precomputedImageEmbedding",
63+
metadata_fields))
64+
65+
6066
def test_get_data_row(datarow, client):
6167
assert client.get_data_row(datarow.uid)
6268

@@ -243,8 +249,9 @@ def test_create_data_row_with_metadata(dataset, image_url):
243249
assert requests.get(image_url).content == \
244250
requests.get(data_row.row_data).content
245251
assert data_row.media_attributes is not None
246-
assert len(data_row.metadata_fields) == 4
247-
assert [m["schemaId"] for m in data_row.metadata_fields
252+
filtered_md_fields = filter_precomputed_embeddings(data_row.metadata_fields)
253+
assert len(filtered_md_fields) == 4
254+
assert [m["schemaId"] for m in filtered_md_fields
248255
].sort() == EXPECTED_METADATA_SCHEMA_IDS
249256

250257

@@ -262,8 +269,9 @@ def test_create_data_row_with_metadata_dict(dataset, image_url):
262269
assert requests.get(image_url).content == \
263270
requests.get(data_row.row_data).content
264271
assert data_row.media_attributes is not None
265-
assert len(data_row.metadata_fields) == 4
266-
assert [m["schemaId"] for m in data_row.metadata_fields
272+
filtered_md_fields = filter_precomputed_embeddings(data_row.metadata_fields)
273+
assert len(filtered_md_fields) == 4
274+
assert [m["schemaId"] for m in filtered_md_fields
267275
].sort() == EXPECTED_METADATA_SCHEMA_IDS
268276

269277

@@ -313,8 +321,11 @@ def test_create_data_rows_with_metadata(dataset, image_url):
313321
assert requests.get(image_url).content == \
314322
requests.get(row.row_data).content
315323
assert row.media_attributes is not None
316-
assert len(row.metadata_fields) == 4
317-
assert [m["schemaId"] for m in row.metadata_fields
324+
325+
# Remove 'precomputedImageEmbedding' metadata if automatically added
326+
filtered_md_fields = filter_precomputed_embeddings(row.metadata_fields)
327+
assert len(filtered_md_fields) == 4
328+
assert [m["schemaId"] for m in filtered_md_fields
318329
].sort() == EXPECTED_METADATA_SCHEMA_IDS
319330

320331

0 commit comments

Comments
 (0)