Skip to content

Commit 2d0a7f0

Browse files
authored
[PLT-1659] Fix handling of global key in ModelEvaluationTemplate (#1869)
2 parents 6fb945c + 05e9679 commit 2d0a7f0

File tree

2 files changed

+3
-4
lines changed

2 files changed

+3
-4
lines changed

libs/labelbox/src/labelbox/schema/data_row_payload_templates.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,6 @@ class ModelEvalutationTemplateRowData(BaseModel):
1515
actors: Dict = Field(default={})
1616
version: int = Field(default=2, frozen=True)
1717
messages: Dict = Field(default={})
18-
global_key: Optional[str] = None
1918

2019

2120
class ModelEvaluationTemplate(BaseModel):
@@ -36,6 +35,7 @@ class ModelEvaluationTemplate(BaseModel):
3635
row_data: ModelEvalutationTemplateRowData = Field(
3736
default=ModelEvalutationTemplateRowData()
3837
)
38+
global_key: Optional[str] = None
3939
attachments: List[Dict] = Field(default=[])
4040
embeddings: List[Dict] = Field(default=[])
4141
metadata_fields: List[DataRowMetadataField] = Field(default=[])

libs/labelbox/tests/integration/test_mmc_data_rows.py

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@ def mmc_data_row(dataset):
2626
def mmc_data_row_all(dataset, make_metadata_fields, embedding):
2727
data = ModelEvaluationTemplate()
2828
data.row_data.rootMessageIds = ["root1"]
29-
data.row_data.global_key = "global_key"
29+
data.global_key = "global_key"
3030
vector = [random.uniform(1.0, 2.0) for _ in range(embedding.dims)]
3131
data.embeddings = [{"embedding_id": embedding.id, "vector": vector}]
3232
data.metadata_fields = make_metadata_fields
@@ -65,9 +65,8 @@ def test_mmc_all(mmc_data_row_all, embedding, constants):
6565
"actors": {},
6666
"messages": {},
6767
"version": 2,
68-
"globalKey": "global_key",
6968
}
70-
69+
assert data_row.global_key == "global_key"
7170
metadata_fields = data_row.metadata_fields
7271
metadata = data_row.metadata
7372
assert len(metadata_fields) == 3

0 commit comments

Comments
 (0)