Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is composer test-coverage obsolete? #21

Open
rarog opened this issue Mar 1, 2021 · 1 comment
Open

Is composer test-coverage obsolete? #21

rarog opened this issue Mar 1, 2021 · 1 comment

Comments

@rarog
Copy link
Contributor

rarog commented Mar 1, 2021

In composer.json there is a definition of command test-coverage, which doesn't seem to be used anymore and perhaps could be deleted.
.travis.yml has a logic to fire this command depending on $TEST_COVERAGE variable, but it's not set anywhere. Also coverage is also done by the normal test command, too as it's defined in phpunit.xml.dist, the generated file clover.xml would just land in a different direction.

@visto9259
Copy link
Member

We moved away from travis in favor of GH actions but you are right, test-coverage does the same as test.

In the GH action, the test matrix does call test-coverage but it should call test instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 🆕 New
Development

No branches or pull requests

2 participants