Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Question: How to install units as a vendored library #341

Open
thorstenhater opened this issue Sep 5, 2024 · 1 comment
Open

Question: How to install units as a vendored library #341

thorstenhater opened this issue Sep 5, 2024 · 1 comment

Comments

@thorstenhater
Copy link

Hi,

I am using units as a git submodule (packaged versions seem not to be widely available, even for Spack).
As units are part of the public API, units needs to be installed along the main project in this setting.
However, I cannot set UNITS_INSTALL=ON in CMake, as cmake_dependent_option will override it
unless PROJECT_NAME is UNITS. Currently, I am overriding PROJECT_NAME, which is less than
desirable.

Could you relax this restriction by checking whether an installation is requested explicitly or, if I am misusing
CMake here, provide a description on what to do instead?

@phlptp
Copy link
Collaborator

phlptp commented Dec 24, 2024

I was looking at this. Not understanding why you can't override UNITS_INSTALL. You will have to set it as a cache level variable but that should override the default options.

set(UNITS_INSTALL ON CACHE INTERNAL "")

And I will be looking into a spack package in the near future, should get it to a 1.0 release within the next year.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants