Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

metric_hyperplane_partitioner is not compatible with key-value containers #81

Open
bwpriest opened this issue Oct 9, 2024 · 0 comments

Comments

@bwpriest
Copy link
Member

bwpriest commented Oct 9, 2024

Currently in v0.3-dev, if you pass a key-value store to saltatlas::dhnsw::partition_data(), such as a ygm::container::map, the for_all()s in saltatlas::metric_hyperplane_partitioner barf because they expect a bag of pairs. The offending lines occur here, here, here, and here.

It should be possible to specify compile-time constexpr conditionals so that the correct signature is used depending on the for_all arguments of the container, although I am not sure if YGM v0.7-dev has a more elegant solution to this.

This issue is currently a blocker on updating hdknn to use v0.3-dev and the simple API.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant