Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

It appears to be possible for saltatlas::dhnsw::dhnsw::query_with_features() to return fewer nearest neighbors than requested #27

Open
bwpriest opened this issue Jan 12, 2023 · 1 comment

Comments

@bwpriest
Copy link
Member

When the total index size is fairly small relative to the parameter k, it appears that query() and query_with_features() can return fewer than k neighbors. Should there be a warning or error thrown when this happens?

@bwpriest
Copy link
Member Author

It looks like the number of partitions and number of hops plays a role, which makes sense. If there are too many partitions and saltatlas cannot find k neighbors within hops neighboring partitions it seems to return whatever it does find. This is probably an edge case, but I feel that we should throw a warning or something when this happens.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant