Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AMSlib: rabbitmq-exchange fields cannot be empty #83

Open
lpottier opened this issue Aug 21, 2024 · 0 comments
Open

AMSlib: rabbitmq-exchange fields cannot be empty #83

lpottier opened this issue Aug 21, 2024 · 0 comments
Assignees
Labels
bug Something isn't working enhancement New feature or request

Comments

@lpottier
Copy link
Collaborator

If the field rabbitmq-exchange is empty AMSlib raises an error (no matter the value of update_surrogate).

{
  {
    "rabbitmq-outbound-queue": "",
    "rabbitmq-exchange": "",
    "rabbitmq-routing-key": ""
  },
  "update_surrogate": false
}

This behavior should be modified to not start an RMQConsumer if update_surrogate is false. If update_surrogate is true and rabbitmq-exchange is empty then we should raise an error.

In addition the fields rabbitmq-outbound-queue, rabbitmq-exchange, rabbitmq-routing-key should be renamed to be more expressive.

@lpottier lpottier added bug Something isn't working enhancement New feature or request labels Aug 21, 2024
@lpottier lpottier self-assigned this Aug 21, 2024
@lpottier lpottier changed the title rabbitmq-exchange fields cannot be empty AMSLib: rabbitmq-exchange fields cannot be empty Aug 21, 2024
@lpottier lpottier changed the title AMSLib: rabbitmq-exchange fields cannot be empty AMSlib: rabbitmq-exchange fields cannot be empty Aug 21, 2024
lpottier added a commit that referenced this issue Sep 18, 2024
Signed-off-by: Loic Pottier <[email protected]>
lpottier added a commit that referenced this issue Nov 7, 2024
Signed-off-by: Loic Pottier <[email protected]>
lpottier added a commit that referenced this issue Dec 11, 2024
Signed-off-by: Loic Pottier <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant