Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document boundaries/blocked attention? #1

Open
jwkirchenbauer opened this issue May 30, 2024 · 1 comment
Open

Document boundaries/blocked attention? #1

jwkirchenbauer opened this issue May 30, 2024 · 1 comment

Comments

@jwkirchenbauer
Copy link

A relatively simple question, that I couldn't quite clarify by looking through the tech report...

During your pretraining (report section 3.1) or instruction tuning phases (report section 3.2), any time samples are "packed together" does your pipeline allow attention masks to cross document boundaries?

@hunterhector
Copy link
Contributor

hunterhector commented May 30, 2024

Right, we didn't add mask there. The hope is to let the model to figure out how to use <eos> or <|endofchat|> to "refresh" the context. @tanyuqian can correct me if I am wrong.

It is a bit unconventional to do it this way with instruction tuning, but packing save us a lot of time. Intuitively, it kinda simulated the scenario where the user ends a prior conversation and starts a new one

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants