Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Potential mistake in Blocking2D structure when a new block is created #340

Open
claireroche opened this issue Nov 29, 2023 · 1 comment
Open
Assignees
Labels
question Further information is requested

Comments

@claireroche
Copy link
Collaborator

claireroche commented Nov 29, 2023

In the Blocking2D.cpp of folder ig/src ,

  1. When we want to create a block using newBlock function, I think there is a mistake while updating the connectivities.

I think lines 95-96:
Node n3 = get<Node>(AN3); n1.add(b);

should be replace by
Node n3 = get<Node>(AN3); n3.add(b);

  1. I think there is a second mistake, at l. 898:
    for(int j = 0; j<getNbDiscretizationI(); j++){

the limit should be on getNbDiscretizationJ()

@claireroche claireroche added the question Further information is requested label Nov 29, 2023
@claireroche claireroche self-assigned this Nov 29, 2023
Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

1 participant