You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I have a warning in CLion when using a variable assignment. This warning is:
"Clang-Tidy: Narrowing conversion from 'gmds::TCellID' (aka 'unsigned int') to signed type 'int' is implementation-defined"
For instance, with the code: Variable<double> *m_distance; double b = m_distance->value(n.id());
Where n is a Node. n.id() is a gmds::TCellID (aka "unsigned int'), but in the class Variable.h, for the method value, here is the method signature: T& value(const int &i) { return m_data[i]; }
(You can find an example on the file AdvectedPointRK4_3D.cpp, at line 254, 255, ...)
Shouldn't the "const int &i" be a "const TCellID &i" ?
The text was updated successfully, but these errors were encountered:
I have a warning in CLion when using a variable assignment. This warning is:
"Clang-Tidy: Narrowing conversion from 'gmds::TCellID' (aka 'unsigned int') to signed type 'int' is implementation-defined"
For instance, with the code:
Variable<double> *m_distance;
double b = m_distance->value(n.id());
Where n is a Node. n.id() is a gmds::TCellID (aka "unsigned int'), but in the class Variable.h, for the method value, here is the method signature:
T& value(const int &i) { return m_data[i]; }
(You can find an example on the file AdvectedPointRK4_3D.cpp, at line 254, 255, ...)
Shouldn't the "const int &i" be a "const TCellID &i" ?
The text was updated successfully, but these errors were encountered: