Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG]: focus follows mouse breaks append container behaviour #978

Open
xrun1 opened this issue Aug 29, 2024 · 0 comments
Open

[BUG]: focus follows mouse breaks append container behaviour #978

xrun1 opened this issue Aug 29, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@xrun1
Copy link

xrun1 commented Aug 29, 2024

Describe the bug
New windows always spawn on the first monitor, in the first container. Log:

2024-08-29T15:40:35.111332Z  INFO process_event{event="TitleUpdate" winevent="ObjectNameChange" hwnd=6360132}: komorebi::process_event: processed: (hwnd: 6360132, title: Terminal, exe: WindowsTerminal.exe, class: CASCADIA_HOSTING_WINDOW_CLASS)
2024-08-29T15:40:35.144634Z  INFO process_event{event="FocusChange" winevent="SystemForeground" hwnd=6360132}:update_focused_workspace{follow_focus=true trigger_focus=false}: komorebi::window_manager: updating
2024-08-29T15:40:35.146067Z ERROR komorebi::process_event:
   0: there is no container/window

Location:
   komorebi\src\workspace.rs:493

  ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ BACKTRACE ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━
                                ⋮ 11 frames hidden ⋮
  12: komorebi::workspace::impl$1::focus_container_by_window::closure$0<unknown>
      at C:\Users\Lambda\Apps\komorebi\komorebi\src\workspace.rs:493
  13: enum2$<core::option::Option<usize> >::ok_or_else<usize,eyre::Report,komorebi::workspace::impl$1::focus_container_by_window::closure_env$0><unknown>
      at /rustc/3f5fd8dd41153bc5fdca9427e9e05be2c767ba23\library\core\src\option.rs:1239
  14: komorebi::workspace::Workspace::focus_container_by_window<unknown>
      at C:\Users\Lambda\Apps\komorebi\komorebi\src\workspace.rs:491
  15: komorebi::window_manager::WindowManager::process_event<unknown>
      at C:\Users\Lambda\Apps\komorebi\komorebi\src\process_event.rs:265
  16: komorebi::process_event::listen_for_events::closure$0<unknown>
      at C:\Users\Lambda\Apps\komorebi\komorebi\src\process_event.rs:49
  17: core::hint::black_box<unknown>
      at /rustc/3f5fd8dd41153bc5fdca9427e9e05be2c767ba23\library\core\src\hint.rs:338
                                ⋮ 14 frames hidden ⋮

Run with COLORBT_SHOW_HIDDEN=1 environment variable to disable frame filtering.
Run with RUST_BACKTRACE=full to include source snippets.
Warning: SpanTrace capture is Unsupported.
Ensure that you've setup a tracing-error ErrorLayer and the semver versions are compatible
2024-08-29T15:40:35.159316Z  INFO process_event{event="TitleUpdate" winevent="ObjectNameChange" hwnd=6360132}: komorebi::process_event: processed: (hwnd: 6360132, title: Windows PowerShell, exe: WindowsTerminal.exe, class: CASCADIA_HOSTING_WINDOW_CLASS)
2024-08-29T15:40:35.175635Z  INFO process_event{event="FocusChange" winevent="SystemForeground" hwnd=11010978}:focus_window{idx=1}: komorebi::container: focusing window
2024-08-29T15:40:35.177971Z  INFO process_event{event="FocusChange" winevent="SystemForeground" hwnd=11010978}:update_focused_workspace{follow_focus=true trigger_focus=false}: komorebi::window_manager: updating
2024-08-29T15:40:35.178511Z  INFO process_event{event="FocusChange" winevent="SystemForeground" hwnd=11010978}:focus_window{idx=1}: komorebi::container: focusing window
2024-08-29T15:40:35.178692Z  INFO process_event{event="FocusChange" winevent="SystemForeground" hwnd=11010978}:focus_container{idx=0}: komorebi::workspace: focusing container
2024-08-29T15:40:35.180796Z  INFO process_event{event="FocusChange" winevent="SystemForeground" hwnd=11010978}: komorebi::process_event: processed: (hwnd: 11010978, title: Administrator: Windows PowerShell, exe: WindowsTerminal.exe, class: CASCADIA_HOSTING_WINDOW_CLASS)
2024-08-29T15:40:35.204094Z  INFO process_event{event="Show" winevent="ObjectShow" hwnd=6360132}:focus_window{idx=2}: komorebi::container: focusing window
2024-08-29T15:40:35.207819Z  INFO process_event{event="Show" winevent="ObjectShow" hwnd=6360132}:update_focused_workspace{follow_focus=true trigger_focus=false}: komorebi::window_manager: updating
2024-08-29T15:40:35.210242Z  INFO process_event{event="Show" winevent="ObjectShow" hwnd=6360132}: komorebi::process_event: processed: (hwnd: 6360132, title: Windows PowerShell, exe: WindowsTerminal.exe, class: CASCADIA_HOSTING_WINDOW_CLASS)
2024-08-29T15:40:35.211749Z  INFO process_event{event="FocusChange" winevent="SystemForeground" hwnd=6360132}:focus_window{idx=2}: komorebi::container: focusing window
2024-08-29T15:40:35.218913Z  INFO process_event{event="FocusChange" winevent="SystemForeground" hwnd=6360132}:update_focused_workspace{follow_focus=true trigger_focus=false}: komorebi::window_manager: updating
2024-08-29T15:40:35.219629Z  INFO process_event{event="FocusChange" winevent="SystemForeground" hwnd=6360132}:focus_window{idx=2}: komorebi::container: focusing window
2024-08-29T15:40:35.219815Z  INFO process_event{event="FocusChange" winevent="SystemForeground" hwnd=6360132}:focus_container{idx=0}: komorebi::workspace: focusing container
2024-08-29T15:40:35.222339Z  INFO process_event{event="FocusChange" winevent="SystemForeground" hwnd=6360132}: komorebi::process_event: processed: (hwnd: 6360132, title: Windows PowerShell, exe: WindowsTerminal.exe, class: CASCADIA_HOSTING_WINDOW_CLASS)
2024-08-29T15:40:35.225347Z  INFO process_event{event="Cloak" winevent="ObjectCloaked" hwnd=11010978}: komorebi::process_event: processed: (hwnd: 11010978, title: Administrator: Windows PowerShell, exe: WindowsTerminal.exe, class: CASCADIA_HOSTING_WINDOW_CLASS)
2024-08-29T15:40:35.306244Z  INFO process_event{event="TitleUpdate" winevent="ObjectNameChange" hwnd=6360132}: komorebi::process_event: processed: (hwnd: 6360132, title: Administrator: Windows PowerShell, exe: WindowsTerminal.exe, class: CASCADIA_HOSTING_WINDOW_CLASS)

To Reproduce
Steps to reproduce the behavior:

  1. Set "window_container_behavior": "Append" and "focus_follows_mouse": "Windows" in komorebi.json
  2. Open any new window (using taskbar or keybind, doesn't matter)

Expected behavior
Window appears in the stacked container that contains the focused window

Operating System
Provide the output of systeminfo | grep "^OS Name\|^OS Version"

For example:

OS Name:                       Microsoft Windows 11 IoT Enterprise LTSC
OS Version:                    10.0.26100 N/A Build 26100

komorebic check Output
Provide the output of komorebic check

No KOMOREBI_CONFIG_HOME detected, defaulting to C:\Users\Lambda

Looking for configuration files in C:\Users\Lambda

Found komorebi.json; this file can be passed to the start command with the --config flag

Found C:\Users\Lambda\.config\whkdrc; key bindings will be loaded from here when whkd is started, and you can start it automatically using the --whkd flag
@xrun1 xrun1 added the bug Something isn't working label Aug 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant