Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BANZAI seems to be producing NaNs for L1FWHM as well as missing values #648

Open
talister opened this issue Aug 19, 2024 · 1 comment
Open
Assignees
Labels
bug intermittent Bugs which only happen sometimes, often with external services

Comments

@talister
Copy link
Member

talister commented Aug 19, 2024

Some recent data declined in quality (clouds rolled in) towards the end of the block, resulting in BANZAI producing NaNs in addition to it's previous behavior of not inserting the L1FWHM keyword if the astrometric fit failed:

FILENAME                             TRACKNUM REQNUM DATE-OBS              OBJECT FILTER L1FWHM
elp1m006-fa08-20240815-0406-e91.fits 2028186 3617621 2024-08-16T08:20:54.584 2024 OY2 w 2.403
elp1m006-fa08-20240815-0407-e91.fits 2028186 3617621 2024-08-16T08:21:10.887 2024 OY2 w ___
elp1m006-fa08-20240815-0408-e91.fits 2028186 3617621 2024-08-16T08:21:27.193 2024 OY2 w ___
elp1m006-fa08-20240815-0409-e91.fits 2028186 3617621 2024-08-16T08:21:43.648 2024 OY2 w NaN
elp1m006-fa08-20240815-0410-e91.fits 2028186 3617621 2024-08-16T08:21:59.810 2024 OY2 w NaN

These should be trapped at Frame creation time and the -99.0 default value inserted.

@talister talister added bug intermittent Bugs which only happen sometimes, often with external services labels Aug 19, 2024
@talister talister self-assigned this Aug 19, 2024
@talister
Copy link
Member Author

talister commented Aug 19, 2024

Plot thickens somewhat as the e91/BANZAI Frame entry has FWHM=None although the original -e91.fits has NaN:

In [489]: Frame.objects.filter(filename__contains='elp1m006-fa08-20240815-0409').values_list('frametype', 'fwhm')
Out[489]: <QuerySet [(91, None), (6, nan), (92, nan), (6, nan)]>

Original files with NaNs for reference (now replaced in the DB):

      elp1m006-fa08-20240815-0409-e92.fits: nan
      elp1m006-fa08-20240815-0410-e92.fits: nan
      elp1m006-fa08-20240815-0411-e92.fits: nan
      elp1m006-fa08-20240815-0412-e92.fits: nan
      elp1m006-fa08-20240815-0413-e92.fits: nan
      elp1m006-fa08-20240815-0417-e92.fits: nan

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug intermittent Bugs which only happen sometimes, often with external services
Projects
None yet
Development

No branches or pull requests

1 participant