Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update_excel #31

Closed
lyralan opened this issue Feb 2, 2023 · 1 comment
Closed

update_excel #31

lyralan opened this issue Feb 2, 2023 · 1 comment

Comments

@lyralan
Copy link
Collaborator

lyralan commented Feb 2, 2023

With the latest Openpyxl (v3.1.0, released on 2023.01.31) leading to errors

AttributeError: 'DefinedNameDict' object has no attribute 'definedName'

when loading an Excel with named ranges in line 77 in adapter, an update in Adapter to be compatible with newer Openpyxl may be needed. An easy solution is to change line 77 to

all_input_ranges = {object_range for object_range in self.wb.defined_names}

However, this is only for folks who use v3.1.0, and this change will lead to backwards incompatibility for users with older Openpyxl versions.

Also, it may be good to check if there's any named ranges or tables in the input file if users specify kind='ranges' or kind='tables'.

@lyralan lyralan changed the title 30_update_excel update_excel Feb 2, 2023
@lyralan
Copy link
Collaborator Author

lyralan commented Jul 1, 2024

Closing this issue as issue 44 further elaborates the latest situation

@lyralan lyralan closed this as completed Jul 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant