Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

metrics by session_id with NA values in column #490

Open
LoannPeurey opened this issue Feb 18, 2025 · 1 comment
Open

metrics by session_id with NA values in column #490

LoannPeurey opened this issue Feb 18, 2025 · 1 comment
Labels
invalid This doesn't seem right

Comments

@LoannPeurey
Copy link
Contributor

LoannPeurey commented Feb 18, 2025

Metrics pipeline fails when NA values in the session_id column, it should throw a meaningful error (currently just 'Index out of bounds')

@LoannPeurey LoannPeurey added the bug Something isn't working label Feb 18, 2025
@lucasgautheron
Copy link
Collaborator

lucasgautheron commented Feb 18, 2025

I don't think it's a bug, as long as the package throws a meaningful exception (e.g. "grouping column {column} has nan values")
But then it should be easy to filter out (manually) the recordings without any session_id.

@LoannPeurey LoannPeurey added invalid This doesn't seem right and removed bug Something isn't working labels Feb 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
invalid This doesn't seem right
Projects
None yet
Development

No branches or pull requests

2 participants