Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

robustness of validation #448

Open
LoannPeurey opened this issue Oct 17, 2023 · 1 comment
Open

robustness of validation #448

LoannPeurey opened this issue Oct 17, 2023 · 1 comment
Assignees
Labels
enhancement New feature or request

Comments

@LoannPeurey
Copy link
Contributor

Is your feature request related to a problem? Please describe.
Failure to read the sample rate of audios during the validation process results in a python error. This happens often on raw audio and should be more robust, as it forces to validate with --ignore-recordings

Describe the solution you'd like
solutions:

  • implement new ways to read sample rate if the first one fails, or another better way
  • continue validation even when not able to read sample rate (have a warning ??)
  • a combination of both previous solutions?
@LoannPeurey LoannPeurey added the enhancement New feature or request label Oct 17, 2023
@LoannPeurey LoannPeurey self-assigned this Oct 31, 2023
@LoannPeurey
Copy link
Contributor Author

LoannPeurey commented Oct 31, 2023

PR #450 added a warning when can't read the sample rate, others ways of getting the sample rate may be explored before closing the issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant