Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enforce dtype = str for certain columns #294

Closed
lucasgautheron opened this issue Sep 24, 2021 · 1 comment · Fixed by #295
Closed

Enforce dtype = str for certain columns #294

lucasgautheron opened this issue Sep 24, 2021 · 1 comment · Fixed by #295
Assignees
Labels
enhancement New feature or request

Comments

@lucasgautheron
Copy link
Collaborator

Is your feature request related to a problem? Please describe.

https://gin.g-node.org/EL1000/lucid/issues/4#issuecomment-1908

Describe the solution you'd like

ChildProject should probably enforced dtype = str for certain columns.
Maybe dtype should be a new property of IndexColumn. This is already what has been done in the experimental #260 branch.

@lucasgautheron lucasgautheron added the enhancement New feature or request label Sep 24, 2021
@lucasgautheron lucasgautheron self-assigned this Sep 24, 2021
@lucasgautheron
Copy link
Collaborator Author

Actually, I think this move may have undesired side-effects. So, instead, I think we should use double quotes around IDs that we want to enforce as strings; This way, reading the metadata with pandas or through the package would yield identical results...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant