Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Depends on JQuery!? #60

Open
bradennapier opened this issue May 25, 2017 · 5 comments
Open

Depends on JQuery!? #60

bradennapier opened this issue May 25, 2017 · 5 comments

Comments

@bradennapier
Copy link

bradennapier commented May 25, 2017

spinners.css claims to be not dependent on JQuery but it is breaking my app because I do not have $ in my global...

$.fn.loaders = function() {
    return this.each(function() {
      var elem = $(this);
      $.each(divs, function(key, value) {
        if (elem.hasClass(key))
          elem.html(addDivs(value))
      })
    });
  };

it tries to load that and fails

Would also be nice to not depend on not using css modules without a hack. Perhaps just having one include the css manually like most other modules work?

@lucianoratamero
Copy link

+1

@NYCJacob
Copy link

+1 I am doing a simple React app with no jquery no bootstrap and it breaks my app.
Uncaught TypeError: Cannot read property 'fn' of undefined
at loaders.css.js:43
at Object. (loaders.css.js:59)
at webpack_require (bootstrap 3b62f8c…:555)
at fn (bootstrap 3b62f8c…:86)
at Object. (index.js:40)
at webpack_require (bootstrap 3b62f8c…:555)
at fn (bootstrap 3b62f8c…:86)
at Object. (Search.js:6)
at webpack_require (bootstrap 3b62f8c…:555)
at fn (bootstrap 3b62f8c…:86)

@taschetto
Copy link

+1... this should not be here :(

Repository owner deleted a comment from kennethpdev Oct 19, 2017
@iBasit
Copy link

iBasit commented Dec 7, 2017

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants