Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: optimize runs api #1324

Merged
merged 2 commits into from
Nov 14, 2024
Merged

Conversation

ffforest
Copy link
Contributor

@ffforest ffforest commented Nov 14, 2024

What type of PR is this?

/kind feature

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

  • Bug where status is set to success when workspace is not found
  • Enhances error message when default backend is not found
  • Runs pagination when listing
  • Panic handling during async executions
  • More logs in run logs
  • Adding a traceID field to runs

Special notes for your reviewer:

Does this PR introduce a user-facing change?


Additional documentation e.g., design docs, usage docs, etc.:


@coveralls
Copy link

coveralls commented Nov 14, 2024

Pull Request Test Coverage Report for Build 11833532075

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 1 of 127 (0.79%) changed or added relevant lines in 8 files are covered.
  • 48 unchanged lines in 5 files lost coverage.
  • Overall coverage decreased (-0.8%) to 48.667%

Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/server/manager/stack/run.go 0 4 0.0%
pkg/infra/persistence/run_model.go 0 8 0.0%
pkg/server/handler/stack/execute_async.go 0 10 0.0%
pkg/server/handler/stack/run.go 0 13 0.0%
pkg/server/handler/stack/utils.go 0 14 0.0%
pkg/infra/persistence/run.go 0 15 0.0%
pkg/server/manager/stack/execute.go 0 26 0.0%
pkg/server/manager/stack/util.go 1 37 2.7%
Files with Coverage Reduction New Missed Lines %
pkg/server/manager/stack/util.go 1 48.45%
pkg/domain/request/workspace_request.go 6 50.0%
pkg/cmd/destroy/destroy.go 7 42.55%
pkg/server/manager/workspace/types.go 15 0.0%
pkg/server/manager/workspace/workspace_manager.go 19 16.0%
Totals Coverage Status
Change from base Build 11830314219: -0.8%
Covered Lines: 10552
Relevant Lines: 21682

💛 - Coveralls

Copy link
Contributor

@liu-hm19 liu-hm19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@liu-hm19 liu-hm19 merged commit 8466ec4 into KusionStack:main Nov 14, 2024
8 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Nov 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants