Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing domain data classes on just_audio package #7

Open
2 tasks
SimoneBressan opened this issue Aug 23, 2022 · 0 comments
Open
2 tasks

Missing domain data classes on just_audio package #7

SimoneBressan opened this issue Aug 23, 2022 · 0 comments
Labels
enhancement New feature or request
Milestone

Comments

@SimoneBressan
Copy link

Implement a domain data class on just_audio package for this classes:

  • DarwinEqualizerParametersMessage -> DarwinEqualizerParameters
  • DarwinEqualizerBandMessage -> DarwinEqualizerBand

NB: Remove a export on just_audio/lib/just_audio.dart file

Personal thinking that requires evaluation:
Consider abstracting the fact that they are platform specific classes. By removing the name and exposing a standard equalizer for both platforms. If unused parameters were passed on one of the two platforms, ignore them and check them with assert

@SimoneBressan SimoneBressan added the enhancement New feature or request label Aug 23, 2022
@kuamanet kuamanet added this to the First release milestone Aug 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants