WIP Use DNSProvider secret ref in DNSPolicy #636
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikenairn
had a problem deploying
to
e2e-internal
GitHub Actions
Failure
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mikenairn The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
maleck13
reviewed
Nov 2, 2023
mikenairn
force-pushed
the
406_dnspolicy_provider_ref
branch
from
d618f57
to
e12b652
Compare
mikenairn
had a problem deploying
to
e2e-internal
GitHub Actions
Failure
mikenairn
force-pushed
the
406_dnspolicy_provider_ref
branch
from
e12b652
to
7a1d761
Compare
mikenairn
had a problem deploying
to
e2e-internal
GitHub Actions
Failure
mikenairn
had a problem deploying
to
e2e-internal
GitHub Actions
Failure
mikenairn
force-pushed
the
406_dnspolicy_provider_ref
branch
from
536554c
to
99fc14e
Compare
mikenairn
had a problem deploying
to
e2e-internal
GitHub Actions
Failure
mikenairn
had a problem deploying
to
e2e-internal
GitHub Actions
Failure
mikenairn
had a problem deploying
to
e2e-internal
GitHub Actions
Failure
mikenairn
had a problem deploying
to
e2e-internal
GitHub Actions
Failure
mikenairn
had a problem deploying
to
e2e-internal
GitHub Actions
Failure
mikenairn
had a problem deploying
to
e2e-internal
GitHub Actions
Failure
mikenairn
force-pushed
the
406_dnspolicy_provider_ref
branch
from
801680c
to
7dce1cc
Compare
mikenairn
had a problem deploying
to
e2e-internal
GitHub Actions
Failure
mikenairn
added a commit
to mikenairn/multi-cluster-traffic-controller
that referenced
this pull request
Nov 15, 2023
Add TEST_MANAGED_ZONE_NAME env var to e2e test suite steps. This will be required for Kuadrant#636, but adding these here now to make life easier testing that PR.
Merged
mikenairn
added a commit
to mikenairn/multi-cluster-traffic-controller
that referenced
this pull request
Nov 15, 2023
Add TEST_MANAGED_ZONE_NAME env var to e2e test suite steps. This will be required for Kuadrant#636, but adding these here now to make life easier testing that PR. Add log to show image for mgc-controller-manager and mgc-policy-controller
mikenairn
added a commit
to mikenairn/multi-cluster-traffic-controller
that referenced
this pull request
Nov 15, 2023
Add TEST_MANAGED_ZONE_NAME env var to e2e test suite steps. This will be required for Kuadrant#636, but adding these here now to make life easier testing that PR. Add log to show image for mgc-controller-manager and mgc-policy-controller
mikenairn
force-pushed
the
406_dnspolicy_provider_ref
branch
from
7dce1cc
to
098f2fc
Compare
mikenairn
had a problem deploying
to
e2e-internal
GitHub Actions
Failure
mikenairn
force-pushed
the
406_dnspolicy_provider_ref
branch
from
098f2fc
to
24e0f34
Compare
mikenairn
had a problem deploying
to
e2e-internal
GitHub Actions
Failure
mikenairn
had a problem deploying
to
e2e-internal
GitHub Actions
Failure
mikenairn
force-pushed
the
406_dnspolicy_provider_ref
branch
from
c00301d
to
5463ba6
Compare
mikenairn
temporarily deployed
to
e2e-internal
GitHub Actions
Inactive
mikenairn
had a problem deploying
to
e2e-internal
GitHub Actions
Failure
mikenairn
force-pushed
the
406_dnspolicy_provider_ref
branch
from
5463ba6
to
2b20c79
Compare
mikenairn
had a problem deploying
to
e2e-internal
GitHub Actions
Failure
mikenairn
commented
Dec 6, 2023
| @@ -5,6 +5,7 @@ on: | |||
| branches: | |||
| - main | |||
| - "release-*" | |||
| - 406_dnspolicy_provider_ref | |||
There was a problem hiding this comment.
ToDo Remove this before merge
mikenairn
had a problem deploying
to
e2e-internal
GitHub Actions
Failure
mikenairn
temporarily deployed
to
e2e-internal
GitHub Actions
Inactive
Removes the requirement for a ManagedZone to be configured for a host in order for the DNSPolicy to create dns records for it. Make DNSRecord.zoneID optional Set specific allowed values for providerRef.Kind Allow a providerRef.Kind of ManagedZone that looks up zones from Managedzones in the current ns (Current behaviour) and loads dns client through the managed zone providerRef. Add logic around zoneAssignment in dnsPolicy, some providerRef.kinds will result in zoneAssignment being false which indicates that a zone is not going to be looked up or assigned to any created DNSRecords. A DNSRecord will be created for all listeners in this case. Created a v1alpha2 API for DNSPolicy, ManagedZone and DNSRecord. v1alpha1 versions are removed and no longer supported. E2E Test Updates * DO NOT MERGE Add 406_dnspolicy_provider_ref branch for testing * Add e2e test for dnspolicy focused on istio gateways and providers * Add suite id and generate a testDomainName to use for all tests in that instance of the suite (Avoids thigns like wildcard hosts being created that coudl affect all instances of a suite running in teh same hosted zone) * Removed all references to managed zones as input to the e2e test suite. Env vars required now are TEST_DNS_ZONE_DOMAIN_NAME, TEST_DNS_ZONE_ID and TEST_DNS_PROVIDER_SECRET_NAME. ManagedZone updates * Make description optional * fix managedZoneListToZoneList - use range index * Make ID and description pointers * Remove hostedzone prefix from AWS hosted zones * Use status id in managedZoneListToZoneList
mikenairn
force-pushed
the
406_dnspolicy_provider_ref
branch
from
2b20c79
to
bb40bb8
Compare
mikenairn
had a problem deploying
to
e2e-internal
GitHub Actions
Failure
mikenairn
had a problem deploying
to
e2e-internal
GitHub Actions
Failure
mikenairn
changed the title
mikenairn
temporarily deployed
to
e2e-internal
GitHub Actions
Inactive
|
/hold Will come back to these changes after #780 is merged, or when all DNS code is moved to it's new repo. |
|
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/close This PR will need to be considerably reworked. Closing for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #715
Removes the requirement for a ManagedZone to be configured for a host in order for the DNSPolicy to create dns records for it.
Implements the
providerRefoption for DNSPolicy, ManagedZone and DNSRecord as described here https://github.com/Kuadrant/architecture/blob/main/rfcs/0005-single-cluster-dnspolicy.mdTodo:
[] Update docs