Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove ManagedZone API #166

Closed
8 of 9 tasks
maleck13 opened this issue Jun 25, 2024 · 2 comments
Closed
8 of 9 tasks

Remove ManagedZone API #166

maleck13 opened this issue Jun 25, 2024 · 2 comments
Assignees
@mikenairn
Labels
kind/epic Epic size/large
Milestone
Kuadrant v1

Comments

@maleck13
Copy link
Collaborator

maleck13 commented Jun 25, 2024 •
edited
Loading

What

Originally ManagedZone was thought of in the context of multiple tenants where we might control the credentals and the zones. This is no longer the case. ManagedZone as remained in place largely as a reference to a credential to the underlying DNS provider. We do not need this indirection. Additionally the ManagedZone API adds some confusion around what should happen when you delete a managed zone resource.

How

Remove the ManagedZone resource and update DNSPolicy to use a provider ref to define a specific secret in that namespace. The dns record controller will propagate this secret to the DNS Record.

These changes to DNS Operator will break kuadrant-operator, so have both PRs ready and approved, before merging the DNS Operator changes.

  • Create RFC rfc for removal of managed zone API architecture#93
  • Propagate secret to DNS Records
  • Update DNS Operator to read secret directly
  • Remove all references to ManagedZone in both DNS Operator and kuadrant-operator
  • Update all existing documentation in both DNS Operator and kuadrant-operator
  • Update existing tests in both DNS Operator and kuadrant-operator
  • Update local-setup in both DNS Operator and kuadrant-operator
  • Update makefile commands in both DNS Operator and kuadrant-operator
  • Bump API version to v1alpha2: DNS Record and DNS Policy

See also Kuadrant/multicluster-gateway-controller#406
@maleck13 maleck13 converted this from a draft issue Jun 25, 2024
@maleck13 maleck13 added the kind/epic Epic label Jun 25, 2024
@maleck13 maleck13 added this to the Kuadrant v1 milestone Jun 25, 2024
@maleck13
Copy link
Collaborator Author

@mikenairn would appreciate any addiitional thoughts you have on this one.

@philbrookes philbrookes moved this to Todo in Kuadrant Jun 27, 2024
@mikenairn mikenairn mentioned this issue Jun 27, 2024
Merged
@maleck13 maleck13 moved this from Todo to In Progress in Kuadrant Jun 27, 2024
@maleck13 maleck13 moved this from In Progress to Todo in Kuadrant Jun 28, 2024
@mikenairn mikenairn self-assigned this Jul 26, 2024
@mikenairn mikenairn moved this from Todo to In Progress in Kuadrant Jul 29, 2024
mikenairn added a commit to mikenairn/dns-operator that referenced this issue Aug 12, 2024
@mikenairn
chore: Remove ManagedZone API(Kuadrant#166)
d32ba59 
Removes the ManagedZone API and all related code and docs.

Signed-off-by: Michael Nairn <[email protected]>
@mikenairn mikenairn mentioned this issue Aug 12, 2024
Merged
1 task
mikenairn added a commit that referenced this issue Aug 12, 2024
@mikenairn
chore: Remove ManagedZone API(#166)
d81a4a9 
Removes the ManagedZone API and all related code and docs.

Signed-off-by: Michael Nairn <[email protected]>
@mikenairn mikenairn moved this from In Progress to Ready For Review in Kuadrant Aug 12, 2024
mikenairn added a commit that referenced this issue Aug 13, 2024
@mikenairn
chore: Remove ManagedZone API(#166)
bf64e9d 
Removes the ManagedZone API and all related code and docs.

Signed-off-by: Michael Nairn <[email protected]>
mikenairn added a commit that referenced this issue Aug 13, 2024
@mikenairn
chore: Remove ManagedZone API(#166)
33e7178 
Removes the ManagedZone API and all related code and docs.

Signed-off-by: Michael Nairn <[email protected]>
mikenairn added a commit that referenced this issue Aug 13, 2024
@mikenairn
chore: Remove ManagedZone API(#166)
edd82c1 
Removes the ManagedZone API and all related code and docs.

Signed-off-by: Michael Nairn <[email protected]>
mikenairn added a commit that referenced this issue Aug 13, 2024
@mikenairn
chore: Remove ManagedZone API(#166)
46cdd6c 
Removes the ManagedZone API and all related code and docs.

Signed-off-by: Michael Nairn <[email protected]>
mikenairn added a commit that referenced this issue Aug 14, 2024
@mikenairn
chore: Remove ManagedZone API(#166)
2b835e4 
Removes the ManagedZone API and all related code and docs.

Signed-off-by: Michael Nairn <[email protected]>
maleck13 pushed a commit that referenced this issue Aug 19, 2024
@mikenairn @maleck13
chore: Remove ManagedZone API(#166)
dd7e59b 
Removes the ManagedZone API and all related code and docs.

Signed-off-by: Michael Nairn <[email protected]>

Signed-off-by: craig <[email protected]>
@maleck13
Copy link
Collaborator Author

Kuadrant/kuadrant-operator#793

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mikenairn mikenairn

Labels
kind/epic Epic size/large
Projects
Kuadrant
Status: Done
Milestone
Kuadrant v1
Development

No branches or pull requests
3 participants
@maleck13 @mikenairn @philbrookes