Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FormTableSection Renderers #740

Open
davidsowerby opened this issue Aug 30, 2018 · 0 comments
Open

FormTableSection Renderers #740

davidsowerby opened this issue Aug 30, 2018 · 0 comments
Labels

Comments

@davidsowerby
Copy link
Collaborator

The Vaadin supplied renderers for Grid.Column are inconsistent in the way they handle locale, and make it difficult to change locale dynamically.

Some use the Grid locale (depending on which constructor is used). This would mean just refreshing the Grid after a locale change :

  • LocalDateTimeRenderer
  • LocalDateRenderer

These are fine, but others use different methods, and cannot be changed post-construction:

  • NumberRenderer requires a locale set at time of construction, or uses the default for NumberFormat
  • DateRenderer (which may never be used now of course) - uses Locale.getDefault() unless explicitly set.

Currently the FormTableSection just uses TextRenderer, but once fixed should use the appropriate column renderers for the data type. All renderers should just use the Grid locale

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant