-
Notifications
You must be signed in to change notification settings - Fork 133
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added "as" attribute for Link tag #265
Merged
Merged
+135
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # src/commonMain/kotlin/generated/gen-consumer-tags.kt # src/commonMain/kotlin/generated/gen-tag-unions.kt # src/jsMain/kotlin/generated/gen-consumer-tags-js.kt # src/wasmJsMain/kotlin/generated/gen-consumer-tags-wasm-js.kt
e5l
approved these changes
May 6, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Hey @severn-everett, thanks for the fix. Merged |
svc-squareup-copybara
pushed a commit
to cashapp/misk
that referenced
this pull request
Jan 15, 2025
| Package | Type | Package file | Manager | Update | Change | |---|---|---|---|---|---| | [org.postgresql:postgresql](https://jdbc.postgresql.org) ([source](https://github.com/pgjdbc/pgjdbc)) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `42.7.4` -> `42.7.5` | | [org.jetbrains.kotlinx:kotlinx-html-jvm](https://github.com/Kotlin/kotlinx.html) | dependencies | misk/gradle/libs.versions.toml | gradle | minor | `0.11.0` -> `0.12.0` | | [org.jooq:jooq](http://www.jooq.org) ([source](https://github.com/jOOQ/jOOQ)) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `3.18.24` -> `3.18.25` | | [com.datadoghq:dd-trace-api](https://github.com/datadog/dd-trace-java) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `1.45.0` -> `1.45.1` | | [com.datadoghq:dd-trace-ot](https://github.com/datadog/dd-trace-java) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `1.45.0` -> `1.45.1` | | [software.amazon.awssdk:sdk-core](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.29.51` -> `2.29.52` | | [software.amazon.awssdk:dynamodb-enhanced](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.29.51` -> `2.29.52` | | [software.amazon.awssdk:dynamodb](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.29.51` -> `2.29.52` | | [software.amazon.awssdk:aws-core](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.29.51` -> `2.29.52` | | [software.amazon.awssdk:bom](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.29.51` -> `2.29.52` | | [software.amazon.awssdk:auth](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.29.51` -> `2.29.52` | --- ### Release Notes <details> <summary>Kotlin/kotlinx.html (org.jetbrains.kotlinx:kotlinx-html-jvm)</summary> ### [`v0.12.0`](https://github.com/Kotlin/kotlinx.html/releases/tag/0.12.0) #### What's Changed - Added HTML templates by [@​e5l](https://github.com/e5l) in Kotlin/kotlinx.html#255 - Replace usage js with WasmJs in README.md by [@​e5l](https://github.com/e5l) in Kotlin/kotlinx.html#257 - Improve Gradle build logic by [@​hfhbd](https://github.com/hfhbd) in Kotlin/kotlinx.html#258 - Use kotlin.test everywhere by [@​hfhbd](https://github.com/hfhbd) in Kotlin/kotlinx.html#259 - Replace custom time handling with kotlin.time.TimeSource by [@​hfhbd](https://github.com/hfhbd) in Kotlin/kotlinx.html#260 - Add contracts to node append and tag declaration calls by [@​severn-everett](https://github.com/severn-everett) in Kotlin/kotlinx.html#264 - Added "as" attribute for Link tag by [@​severn-everett](https://github.com/severn-everett) in Kotlin/kotlinx.html#265 - Added IE-specific values for textarea wrap attribute by [@​severn-everett](https://github.com/severn-everett) in Kotlin/kotlinx.html#266 - Reducing the amount of compiler warnings in gen-enums.kt by [@​severn-everett](https://github.com/severn-everett) in Kotlin/kotlinx.html#269 - Added "referrerpolicy", "media", and "download" attributes for "a" tag by [@​severn-everett](https://github.com/severn-everett) in Kotlin/kotlinx.html#270 - Fixing typo in area attribute by [@​severn-everett](https://github.com/severn-everett) in Kotlin/kotlinx.html#271 - Updating Github Actions and enabling cross-platform testing by [@​severn-everett](https://github.com/severn-everett) in Kotlin/kotlinx.html#272 - Improving Tag Generation by [@​severn-everett](https://github.com/severn-everett) in Kotlin/kotlinx.html#274 - Added srcset attribute to "source" tag by [@​severn-everett](https://github.com/severn-everett) in Kotlin/kotlinx.html#273 - Added "auto" value for "dir" attribute by [@​severn-everett](https://github.com/severn-everett) in Kotlin/kotlinx.html#275 - Upgrading Kotlin to 2.0.0 by [@​severn-everett](https://github.com/severn-everett) in Kotlin/kotlinx.html#282 - Reworked the validation of attribute names to better correspond to HTML standards by [@​severn-everett](https://github.com/severn-everett) in Kotlin/kotlinx.html#276 - Make attribute traits inheritable by [@​severn-everett](https://github.com/severn-everett) in Kotlin/kotlinx.html#280 - Using correct string type for input attribute "autocomplete" by [@​severn-everett](https://github.com/severn-everett) in Kotlin/kotlinx.html#278 - Support android native targets and wasm-wasi by [@​whyoleg](https://github.com/whyoleg) in Kotlin/kotlinx.html#288 #### New Contributors - [@​hfhbd](https://github.com/hfhbd) made their first contribution in Kotlin/kotlinx.html#258 - [@​whyoleg](https://github.com/whyoleg) made their first contribution in Kotlin/kotlinx.html#288 **Full Changelog**: Kotlin/kotlinx.html@0.11.0...0.12.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - "after 6pm every weekday,before 2am every weekday" in timezone Australia/Melbourne, Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 👻 **Immortal**: This PR will be recreated if closed unmerged. Get [config help](https://github.com/renovatebot/renovate/discussions) if that's undesired. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). GitOrigin-RevId: 3e633633f6599555fd8c75c49d915b16242cac27
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #196