Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multithread the server so multiple calls can be carried out at once #5

Open
j6k4m8 opened this issue Jun 6, 2023 · 4 comments
Open
Labels

Comments

@j6k4m8
Copy link
Member

j6k4m8 commented Jun 6, 2023

Configurably, we should multithread the polling server, multiplexing across documents (but not across edits in one document, in case one changes the context of another)

@j6k4m8 j6k4m8 added the server label Jun 6, 2023
@wrongu
Copy link
Contributor

wrongu commented Jun 7, 2023

How about multiprocess rather than multithread here? Proposal:

  • one main process that infrequently polls projects to see if there are any "live" changes happening
  • ...if so, spawn a paper-specific process
  • the per-paper processes shut themselves down when a paper goes quiet for a while

@j6k4m8
Copy link
Member Author

j6k4m8 commented Jun 7, 2023

Totally — love it. Each process can be super lightweight too since 99% of the lifecycle is waiting for an HTTP round-trip...

@j6k4m8
Copy link
Member Author

j6k4m8 commented Jun 7, 2023

...actually pretty low-importance until #10 since git rate limits will prevent this from actually being useful to us.

@wrongu
Copy link
Contributor

wrongu commented Jun 8, 2023

would be nice if polling strat was separate for each paperremote. currently, if one paper is being actively edited, all papers get polled more frequently.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants