Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG : Models.Binder.TextContentBinder.ValidateColumn when ErrorMessage == null #323

Open
sbrickey opened this issue Apr 30, 2015 · 0 comments

Comments

@sbrickey
Copy link

When the validation's error message is null, exceptions are thrown during instantiation of RuleViolation, since validation.ErrorMessage is used as the formatter of String.Format.

ref: http://forum.kooboo.com/yaf_postsm14126_Unable-to-view-Admin-Content-Search-Indexed-Data.aspx#post14126

When adding validators to the content type, 'error message' should probably be marked as required.

Secondly, ColumnValidation should have an overloaded GetErrorMessageFormat which handles null values (default to localized text?), which should replace the use of ErrorMessage when used by TextContentBinder.ValidateColumn... this will address content upgrades, since historical CMS_Data won't necessarily have "good" data.

EDITS:
2015/04/30 : 9:42PM UTC
using latest downloaded v4.3 from CodePlex, which /Admin reports as v4.3.8.218

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant