Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Admission webhook observability #6084

Closed
2 of 4 tasks
dweber019 opened this issue May 24, 2024 · 0 comments · Fixed by #6086 · May be fixed by #6087
Closed
2 of 4 tasks

Admission webhook observability #6084

dweber019 opened this issue May 24, 2024 · 0 comments · Fixed by #6086 · May be fixed by #6087

Comments

@dweber019
Copy link
Contributor

dweber019 commented May 24, 2024

Is there an existing issue for this?

  • I have searched the existing issues

Does this enhancement require public documentation?

  • I have added an Acceptance Criteria item for adding and/or adjusting public documentation (if applicable)

Problem Statement

We are using the admission webhook of KIC but currently it's hard to reason about issues caused by the changes in the admission validation.
Imagine that some change in KIC would cause a lot of httproutes to fail admission validation after an update. How would we know this from a monitoring perspective.

Proposed Solution

  • Add at least a log statement to KIC when an admission fails validation
  • Additionally, it would be nice to have some prometheus metrics about the webhook

Additional information

No response

Acceptance Criteria

  • Add INFO log when a admission is not allowed
  • Add metrics about the admission webhook, like validation count (lables like success=true...)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant