Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Result channel sometimes includes bogus events #120

Open
rainest opened this issue Aug 2, 2024 · 0 comments
Open

Result channel sometimes includes bogus events #120

rainest opened this issue Aug 2, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@rainest
Copy link
Contributor

rainest commented Aug 2, 2024

Testing in the course of writing Kong/kubernetes-ingress-controller#6131 found that the result channel sometimes gets phantom events with no content whatsoever.

I'm not entirely sure where these are coming from, as I couldn't find anything in the code section that sends to them that didn't at least set a static event action type string, and wasn't able to find any other paths somehow sending empty structs into it by watching the buffer in a debugger.

#119 fixes the issue I was seeing where no real results were being sent, but I was still seeing some empty ones come through also.

It was easy enough to just discard these in KIC#6131 as a workaround, and it's quite possible that's sufficient given that we have no other expected consumers of the event channel unless we get around to carving out the deck legacy logger in #22.

@rainest rainest added the bug Something isn't working label Aug 2, 2024
@rainest rainest changed the title Event channel sometimes includes bogus events Result channel sometimes includes bogus events Aug 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant