Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VCPKG port feedback #383

Open
kwsp opened this issue Jul 29, 2024 · 0 comments
Open

VCPKG port feedback #383

kwsp opened this issue Jul 29, 2024 · 0 comments

Comments

@kwsp
Copy link
Contributor

kwsp commented Jul 29, 2024

I'm working on a vcpkg port of Kompute to add to the official index. Here's my working repo for testing the port: https://github.com/kwsp/VcpkgKompute

(For the CMake function vulkan_compile_shader I'm depending on #382)

I would like feedback from the maintainer on 2 issues:

1 . Building with a multi-config generator

I'm able to build and use the port as is with a single configuration build system (e.g. Makefile. To reproduce, clone the test repo and run ./configure_release.sh on *nix with the VCPKG_ROOT env var setup),

However, when I try to use a multi configuration generator (Ninja Multi-Config), I'm getting an error

CMake Error in src/CMakeLists.txt:
  IMPORTED_LOCATION not set for imported target "kompute::kompute"
  configuration "RelWithDebInfo".


CMake Error in src/CMakeLists.txt:
  IMPORTED_LOCATION not set for imported target "kompute::kompute"
  configuration "RelWithDebInfo".


CMake Error in src/CMakeLists.txt:
  IMPORTED_LOCATION not set for imported target "kompute::kompute"
  configuration "RelWithDebInfo".


CMake Error in src/CMakeLists.txt:
  IMPORTED_LOCATION not set for imported target "kompute::kompute"
  configuration "RelWithDebInfo".

To reproduce, clone the test repo and run ./configure_ninja.sh on *nix with the VCPKG_ROOT env var setup.

2. What Kompute build options/features should be exposed as VCPKG features?

Obviously dependencies (e.g. fmt) will be managed by VCPKG so KOMPUTE_OPT_USE_BUILT_IN_FMT=OFF.G I think KOMPUTE_OPT_USE_BUILT_IN_VULKAN_HEADER should be OFF since the user should expect to install the Vulkan SDK?

What other options/features are important to an end user?

Disclaimer: I've not used Kompute extensively in any project yet because I'm a dependency purist and use ALL packages through a vcpkg port, hence I'm working on this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant